refactor passing by ref to by val

Author: trstringer

pkg/systemdtime/systemdtime.go

@@ -118,20 +118,11 @@ func ToDuration(raw string) (time.Duration, error) {
 }
 
 // AdjustTime takes a systemd time adjustment string and uses it to modify a time.Time
-func AdjustTime(original *time.Time, adjustment string) (time.Time, error) {
+func AdjustTime(original time.Time, adjustment string) (time.Time, error) {
 	duration, err := ToDuration(adjustment)
 	if err != nil {
 		return time.Time{}, err
 	}
 
-	return adjustTimeByDuration(original, duration), nil
-}
-
-func adjustTimeByDuration(original *time.Time, adjustment time.Duration) time.Time {
-	if original == nil {
-		rightNow := time.Now()
-		original = &rightNow
-	}
-
-	return original.Add(adjustment)
+	return original.Add(duration), nil
 }

pkg/systemdtime/systemdtime_test.go

@@ -125,7 +125,7 @@ func TestToDuration(t *testing.T) {
 
 func TestAdjustTime(t *testing.T) {
 	time1 := time.Date(2012, time.May, 12, 5, 0, 0, 0, time.UTC)
-	time1Mod, err := AdjustTime(&time1, " 4 days 2 hr")
+	time1Mod, err := AdjustTime(time1, " 4 days 2 hr")
 	if err != nil {
 		t.Error(err)
 	}