fix: do not always check auth header with ws #1450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhiqiang ZHOU <[email protected]>
Author
|
Safari / WebKit does not send basic auth header with web socket request, so ttyd would not works with iPad, iPhone, because actually all browser on apple's mobile device are actually based on WebKit. |
tsl0922
reviewed
Jul 2, 2025
|
|
||
| // Skip Basic Auth check for WebSocket path when credentials are configured | ||
| // Safari doesn't support Basic Auth headers with WebSocket, rely on AuthToken instead | ||
| if (server->credential == NULL || server->auth_header != NULL) { |
Owner
There was a problem hiding this comment.
What if I configured credential only?
There was a problem hiding this comment.
What if I configured credential only?
Hello, I've added a "bell" pull would you be interested in checking it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1437
we have already used
AuthTokenwith WebSocket, so the basic auth header is not required