Skip to content

Commit b077119

Browse files
authored
Merge pull request #1183 from twmb/714-ll
kgo: info=>debug for a few logs in client metrics
2 parents ec36595 + e86bb6c commit b077119

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pkg/kgo/metrics_714.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ func (cl *Client) pushMetrics() {
5252
err = kerr.ErrorForCode(gresp.ErrorCode)
5353
}
5454
if err != nil {
55-
cl.cfg.logger.Log(LogLevelInfo, "unable to get telemetry subscriptions, retrying in 30s", "err", err)
55+
cl.cfg.logger.Log(LogLevelDebug, "unable to get telemetry subscriptions, retrying in 30s", "err", err)
5656
after := time.NewTimer(30 * time.Second)
5757
select {
5858
case <-cl.ctx.Done():
@@ -69,7 +69,7 @@ func (cl *Client) pushMetrics() {
6969
// and re-get.
7070
if len(gresp.RequestedMetrics) == 0 {
7171
wait := time.Duration(gresp.PushIntervalMillis) * time.Millisecond
72-
cl.cfg.logger.Log(LogLevelInfo, "no metrics requested, sleeping and asking again later", "sleep", wait)
72+
cl.cfg.logger.Log(LogLevelDebug, "no metrics requested, sleeping and asking again later", "sleep", wait)
7373
after := time.NewTimer(wait)
7474
select {
7575
case <-cl.ctx.Done():
@@ -165,7 +165,7 @@ func (cl *Client) pushMetrics() {
165165
}
166166
}
167167
if err != nil {
168-
cl.cfg.logger.Log(LogLevelWarn, "unable to send client metrics, resetting subscription", "err", err)
168+
cl.cfg.logger.Log(LogLevelDebug, "unable to send client metrics, resetting subscription", "err", err)
169169
break
170170
}
171171

@@ -190,10 +190,10 @@ func (cl *Client) pushMetrics() {
190190
cl.cfg.logger.Log(LogLevelInfo, "client metrics compression is not supported by the broker even though we only used previously supported compressors, re-getting our subscription information", "err", err)
191191
default:
192192
if !kerr.IsRetriable(err) {
193-
cl.cfg.logger.Log(LogLevelError, "client metrics received an unknown error we do not know how to handle, exiting metrics loop", "err", err)
193+
cl.cfg.logger.Log(LogLevelWarn, "client metrics received an unknown error we do not know how to handle, exiting metrics loop", "err", err)
194194
return
195195
}
196-
cl.cfg.logger.Log(LogLevelWarn, "client metrics received an unknown error that is retryably, continuing to next push cycle", "err", err)
196+
cl.cfg.logger.Log(LogLevelWarn, "client metrics received an unknown error that is retriable, continuing to next push cycle", "err", err)
197197
}
198198
}
199199
}

0 commit comments

Comments
 (0)