Fix missing novnc files

[SimonFair]

Summary by CodeRabbit

• Chores
  • Added configuration files for VM manager integration setup

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Two new JSON configuration files are added to the novnc component of the dynamix.vm.manager plugin. Both files contain empty JSON objects and serve as placeholder configuration structures without any key-value pairs.

Changes

Cohort / File(s)	Summary
novnc Configuration Files emhttp/plugins/dynamix.vm.manager/novnc/defaults.json, emhttp/plugins/dynamix.vm.manager/novnc/mandatory.json	Added new empty JSON object placeholder files for novnc defaults and mandatory configuration. No functional logic or data included.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Both files are empty JSON placeholders with no configuration data or logic to review.

Poem

🐰 Two JSON files, empty and clean,
Config placeholders, fit for a novnc scene,
Defaults and mandatory, standing in place,
Ready for settings to fill up the space! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: adding two missing novnc JSON configuration files to fix a deficiency in the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fa0abe and 77b8cc7.

📒 Files selected for processing (2)

• emhttp/plugins/dynamix.vm.manager/novnc/defaults.json (1 hunks)
• emhttp/plugins/dynamix.vm.manager/novnc/mandatory.json (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: ljm42
Repo: unraid/webgui PR: 2414
File: etc/rc.d/rc.nginx:374-376
Timestamp: 2025-10-03T02:57:29.994Z
Learning: Repo unraid/webgui: In etc/rc.d/rc.nginx, maintainers prefer not to add explicit mv-failure checks or EXIT trap clearing around atomic writes in build_servers(), build_locations(), and build_ini(); treat mv failures (e.g., disk full/permissions) as non-recoverable and keep the implementation simple.

🔇 Additional comments (2)

emhttp/plugins/dynamix.vm.manager/novnc/defaults.json (1)

1-1: Clarify intent of empty JSON objects.

Given the file names suggest configuration purposes (mandatory.json, defaults.json), please confirm whether:

• These files intentionally remain empty as placeholders for future configuration
• They should contain an initial schema structure (e.g., {} for object-type configs or [] for array-type configs)
• Documentation exists about the expected structure and purpose of each file

This will help ensure the PR fully addresses the issue and follows the project's configuration conventions.

emhttp/plugins/dynamix.vm.manager/novnc/mandatory.json (1)

1-1: I'm unable to complete the verification at this time due to persistent repository access issues preventing the codebase from being cloned. Without access to the repository, I cannot:

1. Search for actual references to mandatory.json and defaults.json in the codebase
2. Determine how the novnc integration loads these configuration files
3. Verify if empty objects {} are the intended schema or if they need initial structure
4. Confirm whether this PR fully addresses the "missing novnc files" issue

Manual verification required. Please run the verification script provided in the review comment to determine:

• Whether these JSON files are actually imported/required anywhere
• The intended structure for these placeholder files (confirm empty objects are correct)
• Whether the PR fully resolves the missing novnc files issue

The concern remains valid until someone with repository access can confirm these three points.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2025.11.26.1700
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

1. Go to Plugins → Install Plugin
2. Copy and paste this URL:

https://preview.dl.unraid.net/pr-plugins/pr-2466/webgui-pr-2466.plg

3. Click Install

Alternative: Direct Download

• 📦 Download PLG
• 📦 Download TXZ

⚠️ Important Notes:

• Testing only: This plugin is for testing PR changes
• Backup included: Original files are automatically backed up
• Easy removal: Files are restored when plugin is removed
• Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list

emhttp/plugins/dynamix.vm.manager/novnc/defaults.json
emhttp/plugins/dynamix.vm.manager/novnc/mandatory.json

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2466, or run:

plugin remove webgui-pr-2466

---

_{🤖 This comment is automatically generated and will be updated with each new push to this PR.}