OpenShift compatibility #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ajruckman <[email protected]>
ajruckman
force-pushed
the
feature/openshift_compat
branch
from
70fc7ed to
fb9dcfd
Compare
Collaborator
|
Hi @ajruckman, sorry for the delay reviewing this. I'll rebase against the current main branch. My understanding is that if adaptSecurityContext is set to force, or if it is set to auto and Helm detects the cluster runs OpenShift, then "fsGroup", "runAsUser" and "runAsGroup" are removed from Security Context, and it will use whatever the OpenShift environment tells it to run. Is that correct? I don't quite get "seLinuxOptions", does it also need to be removed? Would the values below achieve the same result? podSecurityContext:
fsGroup: null
runAsUser: null
runAsGroup: null
securityContext:
runAsUser: null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OpenShift compatibility by introducing
compat.openshift.adaptSecurityContext(auto|force|disabled) and a helper that detects OpenShift. Adapts pod/containersecurityContextwithout changing defaults on vanilla Kubernetes.This approach is similar to the pattern used by Bitnami's Valkey chart, which we are glad to have an official alternative to :)