fix: add missing is_encoder_decoder arg #4688
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR fixes a
pydantic.ValidationErrorin the unit tests caused by recent changes in the upstream vLLM project.Upstream vLLM PR #29859 removed the default value for
is_encoder_decoderinSchedulerConfig, making it a required argument during initialization. As a result, the existing unit testtests/ut/core/test_schedule_config.pywas failing.is_encoder_decoder=Falsewhen initializingSchedulerConfigintests/ut/core/test_schedule_config.pyto match the updated upstream class definition.