Skip to content

fix(suspense): defer clearing fallback vnode el in case it has dirs #14080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+38 −2
Open

fix(suspense): defer clearing fallback vnode el in case it has dirs #14080

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e4df55
fix(suspense): defer clearing fallback vnode reference to should unmo…
linzhe141 Nov 12, 2025
f6ec775
chore: add unit test
linzhe141 Nov 12, 2025
0a9d60a
chore: tweaks
edison1105 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/runtime-core/src/components/Suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
type RendererInternals,
type RendererNode,
type SetupRenderEffectFn,
queuePostRenderEffect,
} from '../renderer'
import { queuePostFlushCb } from '../scheduler'
import { filterSingleRoot, updateHOCHostEl } from '../componentRenderUtils'
Expand Down Expand Up @@ -553,9 +554,11 @@ function createSuspenseBoundary(
)
queuePostFlushCb(effects)
// clear el reference from fallback vnode to allow GC after transition
if (isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
queuePostRenderEffect(() => {
if (isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
}, suspense)
}
}
}
Expand All @@ -577,9 +580,11 @@ function createSuspenseBoundary(
unmount(activeBranch, parentComponent, suspense, true)
// clear el reference from fallback vnode to allow GC
// only clear immediately if there's no delayed transition
if (!delayEnter && isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
queuePostRenderEffect(() => {
if (!delayEnter && isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
}, suspense)
}
if (!delayEnter) {
// move content from off-dom container to actual container
Expand Down
Loading