-
Notifications
You must be signed in to change notification settings - Fork 320
Clarify cache access in Handle Fetch #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The previous wording "the registration’s storage key’s name to cache map" was ambiguous. This change clarifies the mechanism for accessing caches during a fetch event handled by a service worker. Specifically, it replaces the ambiguous phrase with a direct call to "obtain a local storage bottle map" from the Storage specification, using the reserved client's environment. This makes the process of retrieving the cache map explicit and aligns the specification with modern storage standards. This addresses the issue raised in w3c#1784
|
@annevk Will you take a look? |
|
@sisidovski @domenic Upon #1784, I fixed the sentences on looking up the cache for the SW static routing API. It has been changed to use "obtain a local storage bottle map" in the storage specification, and uses reserved client as an environment. |
|
How is this related to whatwg/storage#185? |
This PR is the scenario without the change. |
domenic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
Co-authored-by: Domenic Denicola <[email protected]>
|
@monica-ch Can I ask you to take a look? |
|
Thanks for the review, all. |
SHA: 953b6d3 Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 953b6d3 Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 953b6d3 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The previous wording "the registration’s storage key’s name to cache map" was ambiguous. This change clarifies the mechanism for accessing caches during a fetch event handled by a service worker.
Specifically, it replaces the ambiguous phrase with a direct call to "obtain a local storage bottle map" from the Storage specification, using the reserved client's environment. This makes the process of retrieving the cache map explicit and aligns the specification with modern storage standards.
This addresses the issue raised in #1784
Preview | Diff