Add autocomplete_allow_unpublished attribute to target model to allow unpublished pages to be returned by search #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks, @tbock! We'll look over this feature soon. |
SaptakS
requested changes
Jan 30, 2023
Collaborator
SaptakS
left a comment
SaptakS
left a comment
There was a problem hiding this comment.
@tbock the code mostly looks good to me. Can you also add documentation about this feature as part of this PR? You can find the list of things we usually need before merging a PR in our Contribution Guidelines
Contributor
|
Before finding this PR, I took another approach here: #182. Happy to go with either approach and take this feature over the finish line, if anyone is willing to review it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips returning live and returns the base queryset instead.