Fix Galaxy lint issues

Author: Tobias Richter

defaults/main.yml

@@ -65,4 +65,3 @@ aem_cms_in_place_upgrade_paths:
     - "6.4.0"
 # "from_version":
 #    - "to_version" # list of versions that an upgrade is allowed for
-

meta/main.yml

@@ -33,5 +33,5 @@ dependencies:
     version: 2.19.1,
     java_remove_download: false,
     tags: "dev.java",
-    when: aem_cms_dependency_java == true
-  }
+    when: aem_cms_dependency_java
+  }

tasks/in_place_upgrade.yml

@@ -1,7 +1,7 @@
 # get the latest version of all the existing jar files
 - name: "in_place_upgrade : detect version to upgrade from."
   set_fact:
-     aem_cms_in_place_upgrade_existing_version: "{{ aem_cms_in_place_upgrade_existing_quickstarts | map('regex_replace', '^.*cq-quickstart-(.+)-standalone-quickstart.jar$', '\\1') | list | sort | reverse | list | first}}"
+     aem_cms_in_place_upgrade_existing_version: "{{ aem_cms_in_place_upgrade_existing_quickstarts | map('regex_replace', '^.*cq-quickstart-(.+)-standalone-quickstart.jar$', '\\1') | list | sort | reverse | list | first }}"
 
 # safe gate which only allows upgrades when allowed
 - name: "in_place_upgrade : fail when upgrade is not allowed."
@@ -38,4 +38,4 @@
 - name: "in_place_upgrade : create a backup of existing quickstart(s)."
   command: "mv {{ item }} {{ item }}.bak"
   changed_when: true
-  with_items: "{{ aem_cms_in_place_upgrade_existing_quickstarts }}"
+  with_items: "{{ aem_cms_in_place_upgrade_existing_quickstarts }}"

tasks/main.yml

@@ -55,7 +55,11 @@
      - aem_cms_in_place_upgrade_existing_quickstarts | length > 0
 
 - name: Unpack AEM.
-  shell: "su {{ aem_cms_user }} -l -c 'java -jar {{ aem_cms_download_path }}/{{ aem_cms_quickstart_name }} -unpack -b {{ aem_cms_home }}'"
+  shell: >-
+    su {{ aem_cms_user }} -l -c
+    'java -jar {{ aem_cms_download_path }}/{{ aem_cms_quickstart_name }}
+    -unpack
+    -b {{ aem_cms_home }}'
   args:
     creates: "{{ aem_cms_home }}/crx-quickstart/app/cq-quickstart-{{ aem_cms_version }}-standalone-quickstart.jar"
     warn: false
@@ -82,4 +86,4 @@
 
 - name: Setup i386 support for XMPFilesProcessor.
   include: xmp_i386.yml
-  when: ansible_architecture == 'x86_64'
+  when: ansible_architecture == 'x86_64'