[jgitflow-maven-plugin] merging 'release/2.0.0' into 'master'

Author: apegam-pv

.travis.maven-settings.xml

@@ -31,7 +31,7 @@
 
         <repository>
           <id>central</id>
-          <url>http://repo1.maven.org/maven2/</url>
+          <url>https://repo1.maven.org/maven2/</url>
           <layout>default</layout>
           <releases>
             <enabled>true</enabled>
@@ -57,7 +57,7 @@
 
         <repository>
           <id>wcm-io-apache-intermediate-release</id>
-          <url>http://wcm.io/maven/repositories/apache-intermediate-release</url>
+          <url>https://wcm.io/maven/repositories/apache-intermediate-release</url>
           <layout>default</layout>
           <releases>
             <enabled>true</enabled>
@@ -83,7 +83,7 @@
 
         <repository>
           <id>apache-snapshots</id>
-          <url>http://repository.apache.org/snapshots</url>
+          <url>https://repository.apache.org/snapshots</url>
           <layout>default</layout>
           <releases>
             <enabled>false</enabled>
@@ -100,7 +100,7 @@
 
         <pluginRepository>
           <id>central</id>
-          <url>http://repo1.maven.org/maven2/</url>
+          <url>https://repo1.maven.org/maven2/</url>
           <layout>default</layout>
           <releases>
             <enabled>true</enabled>
@@ -126,7 +126,7 @@
 
         <pluginRepository>
           <id>wcm-io-apache-intermediate-release</id>
-          <url>http://wcm.io/maven/repositories/apache-intermediate-release</url>
+          <url>https://wcm.io/maven/repositories/apache-intermediate-release</url>
           <layout>default</layout>
           <releases>
             <enabled>true</enabled>
@@ -152,7 +152,7 @@
 
         <pluginRepository>
           <id>apache-snapshots</id>
-          <url>http://repository.apache.org/snapshots</url>
+          <url>https://repository.apache.org/snapshots</url>
           <layout>default</layout>
           <releases>
             <enabled>false</enabled>

.travis.yml

@@ -20,7 +20,7 @@
 language: java
 
 jdk:
-- oraclejdk8
+- openjdk8
 - openjdk11
 
 # Make sure travis can use container-based infrastructure

README.md

@@ -1,4 +1,4 @@
-<img src="http://wcm.io/images/[email protected]"/> Selenium Galen Integration
+<img src="https://wcm.io/images/[email protected]"/> Selenium Galen Integration
 ==========================
 [![Build Status](https://travis-ci.org/wcm-io-qa/wcm-io-qa-galenium.png?branch=develop)](https://travis-ci.org/wcm-io-qa/wcm-io-qa-galenium) 
 
@@ -7,5 +7,5 @@ This project is an attempt to integrate Galen with Selenium and the other way ar
 To get an idea how it works, take a look at the [documentation].
 
 
-[documentation]: http://qa.wcm.io/galenium/
+[documentation]: https://qa.wcm.io/galenium/
 

examples/README.md

@@ -6,7 +6,7 @@ This project contains some examples for how to integrate Galenium into your proj
 Run Example Project
 -------------------
 
-[wcm-io-sample](http://wcm.io/samples/) has to be deployed to an AEM instance running on *localhost* on port *4502* and you need to have Chrome installed.
+[wcm-io-sample](https://wcm.io/samples/) has to be deployed to an AEM instance running on *localhost* on port *4502* and you need to have Chrome installed.
 
 If you have that, you just run the Maven command:
 

examples/pom.xml

@@ -23,15 +23,15 @@
   <parent>
     <groupId>io.wcm.maven</groupId>
     <artifactId>io.wcm.maven.global-parent</artifactId>
-    <version>25</version>
+    <version>26</version>
     <relativePath />
   </parent>
 
   <name>Galenium Examples</name>
   <groupId>io.wcm.qa</groupId>
   <artifactId>io.wcm.qa.galenium.examples</artifactId>
   <packaging>pom</packaging>
-  <version>1.0.0</version>
+  <version>2.0.0</version>
   <description>Test automation examples.</description>
 
   <properties>

examples/specs/pom.xml

@@ -23,15 +23,15 @@
   <parent>
     <groupId>io.wcm.qa</groupId>
     <artifactId>io.wcm.qa.galenium.integration.specs</artifactId>
-    <version>1.0.0</version>
+    <version>2.0.0</version>
     <relativePath>../../integration/specs</relativePath>
   </parent>
 
   <name>Galenium Example Specs</name>
   <groupId>io.wcm.qa</groupId>
   <artifactId>io.wcm.qa.galenium.examples.specs</artifactId>
   <packaging>jar</packaging>
-  <version>1.0.0</version>
+  <version>2.0.0</version>
   <description>Test automation example Galen specs.</description>
 
   <properties>

examples/tests/pom.xml

@@ -23,15 +23,15 @@
   <parent>
     <groupId>io.wcm.qa</groupId>
     <artifactId>io.wcm.qa.galenium.integration.ui-tests</artifactId>
-    <version>1.0.0</version>
+    <version>2.0.0</version>
     <relativePath>../../integration/ui-tests</relativePath>
   </parent>
 
   <name>Galenium Example Tests</name>
   <groupId>io.wcm.qa</groupId>
   <artifactId>io.wcm.qa.galenium.examples.tests</artifactId>
   <packaging>jar</packaging>
-  <version>1.0.0</version>
+  <version>2.0.0</version>
   <description>Test automation example tests.</description>
 
   <properties>
@@ -44,7 +44,7 @@
     <dependency>
       <groupId>io.wcm.qa</groupId>
       <artifactId>io.wcm.qa.galenium.examples.specs</artifactId>
-      <version>1.0.0</version>
+      <version>2.0.0</version>
     </dependency>
 
   </dependencies>
@@ -97,11 +97,6 @@
             </configuration>
           </plugin>
 
-          <!-- Webdriver download -->
-          <plugin>
-            <groupId>com.lazerycode.selenium</groupId>
-            <artifactId>driver-binary-downloader-maven-plugin</artifactId>
-          </plugin>
 
         </plugins>
       </build>

examples/tests/src/test/java/io/wcm/qa/galenium/example/ImageComparisonIT.java

@@ -22,22 +22,18 @@
 import org.testng.annotations.Factory;
 import org.testng.annotations.Test;
 
-import com.galenframework.reports.model.LayoutReport;
-
 import io.wcm.qa.galenium.device.TestDevice;
-import io.wcm.qa.galenium.differences.difference.BrowserDifference;
-import io.wcm.qa.galenium.differences.difference.ScreenWidthDifference;
+import io.wcm.qa.galenium.differences.difference.driver.BrowserDifference;
+import io.wcm.qa.galenium.differences.difference.driver.ScreenWidthDifference;
 import io.wcm.qa.galenium.example.selectors.common.Page;
 import io.wcm.qa.galenium.example.selectors.homepage.Stage;
-import io.wcm.qa.galenium.galen.GalenHelperUtil;
-import io.wcm.qa.galenium.galen.GalenLayoutChecker;
-import io.wcm.qa.galenium.imagecomparison.ImageComparisonSpecFactory;
-import io.wcm.qa.galenium.imagecomparison.ImageComparisonValidationListener;
 import io.wcm.qa.galenium.providers.TestDeviceProvider;
 import io.wcm.qa.galenium.selectors.base.Selector;
+import io.wcm.qa.galenium.verification.element.VisualVerification;
+import io.wcm.qa.galenium.verification.util.Check;
 
 /**
- * Example of how to use the {@link ImageComparisonSpecFactory} to compare individual elements on a page.
+ * Example of how to use the {@link VisualVerification} to compare individual elements on a page.
  */
 public class ImageComparisonIT extends AbstractExampleBase {
 
@@ -55,33 +51,23 @@ public void compareSomeImages() {
 
   private void checkVisually(Selector selector) {
     // get factory for comparing element
-    ImageComparisonSpecFactory factory = new ImageComparisonSpecFactory(selector);
+    VisualVerification verification = new VisualVerification(selector);
 
     // add a no tolerance check at warning level
-    factory.setZeroToleranceWarning(true);
+    verification.setZeroToleranceWarning(true);
+
+    // allow error percent
+    verification.setAllowedErrorPercent(2.0);
 
     // allow offset
-    factory.setAllowedOffset(2);
+    verification.setAllowedOffset(2);
 
     // browser and viewport width will make a difference
-    factory.addDifference(new BrowserDifference());
-    factory.addDifference(new ScreenWidthDifference());
+    verification.addDifference(new BrowserDifference());
+    verification.addDifference(new ScreenWidthDifference());
 
     // compare image using spec
-    LayoutReport layoutReport = GalenLayoutChecker.checkLayout(
-        "Image comparison stage",
-        factory.getPageSpecInstance(),
-        getDevice(),
-        GalenHelperUtil.getSectionFilter(getDevice()),
-        getValidationListener());
-    String specName = "image_comparison_" + selector.elementName() + ".gspec";
-    String errorMessage = "FAILED: Layoutcheck " + specName + " with device " + getDevice();
-    String successMessage = "successfully ran spec: " + specName;
-    GalenLayoutChecker.handleLayoutReport(layoutReport, errorMessage, successMessage);
-  }
-
-  private ImageComparisonValidationListener getValidationListener() {
-    return new ImageComparisonValidationListener();
+    Check.verify(verification);
   }
 
   @Override

examples/tests/src/test/java/io/wcm/qa/galenium/example/VerificationIT.java

@@ -25,8 +25,8 @@
 import org.testng.annotations.Test;
 
 import io.wcm.qa.galenium.device.TestDevice;
-import io.wcm.qa.galenium.differences.difference.BrowserDifference;
-import io.wcm.qa.galenium.differences.difference.ScreenWidthDifference;
+import io.wcm.qa.galenium.differences.difference.driver.BrowserDifference;
+import io.wcm.qa.galenium.differences.difference.driver.ScreenWidthDifference;
 import io.wcm.qa.galenium.example.pageobjects.Homepage;
 import io.wcm.qa.galenium.example.selectors.common.Page;
 import io.wcm.qa.galenium.example.selectors.common.Page.Navigation;