Run eslint on all code

But don't bother fixing line lengths for existing code.

Author: foolip

git-write.js

@@ -1,3 +1,5 @@
+/* eslint-disable max-len */
+
 'use strict';
 
 const fetch = require('node-fetch');
@@ -31,7 +33,7 @@ async function writeReportToGit(report, repo, commitMessage, tagName) {
   // tree is traversed depth first to write all of the trees.
   async function emptyTree() {
     const builder = await Git.Treebuilder.create(repo, null);
-    return { builder, subtrees: new Map };
+    return {builder, subtrees: new Map};
   }
 
   const rootTree = await emptyTree();
@@ -58,10 +60,10 @@ async function writeReportToGit(report, repo, commitMessage, tagName) {
     return tree.builder.write();
   }
 
-  let blobCache = new Map;
+  const blobCache = new Map;
 
   function isJSONObject(v) {
-    return typeof v === "object" && v !== null && !Array.isArray(v);
+    return typeof v === 'object' && v !== null && !Array.isArray(v);
   }
 
   // Keep only a fixed set of keys. This filters out at least:
@@ -72,9 +74,10 @@ async function writeReportToGit(report, repo, commitMessage, tagName) {
   //  - "screenshots" which contains screenshot hashes
   //  - "test" which is the test path, and will be represented elsewhere
   // Note that "" is the dummy key value for the initial object.
-  const keepKeys = new Set(["", "name", "status", "subtests"]);
+  const keepKeys = new Set(['', 'name', 'status', 'subtests']);
 
   function replacer(key, value) {
+    // eslint-disable-next-line no-invalid-this
     if (isJSONObject(this)) {
       if (!keepKeys.has(key)) {
         return undefined;

lib/browser-specific.js

@@ -1,3 +1,5 @@
+/* eslint-disable max-len */
+
 'use strict';
 
 /**

lib/index.js

@@ -4,4 +4,4 @@ const browserSpecific = require('./browser-specific');
 const results = require('./results');
 const runs = require('./runs');
 
-module.exports = { browserSpecific, results, runs };
+module.exports = {browserSpecific, results, runs};

lib/results.js

@@ -1,3 +1,5 @@
+/* eslint-disable max-len */
+
 'use strict';
 
 /**
@@ -48,12 +50,16 @@ function oidToKey(oid) {
 
 const newTreeId = (() => {
   let id = 0;
-  return () => { return ++id; };
+  return () => {
+    return ++id;
+  };
 })();
 
 const newTestId = (() => {
   let id = 0;
-  return () => { return ++id; };
+  return () => {
+    return ++id;
+  };
 })();
 
 async function readResults(entry) {
@@ -72,16 +78,17 @@ async function readResults(entry) {
   const buffer = blob.content();
   const results = JSON.parse(buffer);
 
-  if (results.id !== undefined)
+  if (results.id !== undefined) {
     throw new Error('Results JSON already has an "id" field; code needs changed');
+  }
   results.id = newTestId();
 
   testCache[key] = results;
   return results;
 }
 
 async function readTree(treeOrEntry) {
-  let tree, entry, oid;
+  let tree; let entry; let oid;
   if (treeOrEntry instanceof Git.Tree) {
     tree = treeOrEntry;
     oid = tree.id();
@@ -121,7 +128,7 @@ async function readTree(treeOrEntry) {
       name = decodeURIComponent(name.substr(0, name.length - 5));
       newTree.tests[name] = await readResults(entry);
     } else {
-      throw new TypeError('y not tree or blob?')
+      throw new TypeError('y not tree or blob?');
     }
   }
 
@@ -157,18 +164,14 @@ async function getLocalRunIds(repo) {
 //
 // Where test_results is an object as described in the module documentation.
 function walkTests(tree, visitor, path='') {
-  const subtrees = tree.trees;
-  for (const dir in subtrees) {
-    const subtree = subtrees[dir];
+  for (const [dir, subtree] of Object.entries(tree.trees)) {
     walkTests(subtree, visitor, `${path}/${dir}`);
   }
 
-  const tests = tree.tests;
-  for (const name in tests) {
-    const results = tests[name];
+  for (const [name, results] of Object.entries(tree.tests)) {
     visitor(path, name, results);
   }
 }
 
 // treeCache, testCache exposed only for git-query.js to report memory stats.
-module.exports = { getGitTree, getLocalRunIds, walkTests, treeCache, testCache };
+module.exports = {getGitTree, getLocalRunIds, walkTests, treeCache, testCache};

package.json

@@ -9,7 +9,7 @@
   },
   "scripts": {
     "install": "git clone --bare https://github.com/web-platform-tests/results-analysis-cache.git && git --git-dir=results-analysis-cache.git remote set-url --push origin [email protected]:web-platform-tests/results-analysis-cache.git || git --git-dir=results-analysis-cache.git fetch --tags",
-    "lint": "eslint browser-specific-failures.js lib/browser-specific.js lib/runs.js compat-2021/main.js interop-2022/main.js interop-scoring/main.js",
+    "lint": "eslint .",
     "test": "npm run lint && npm run test-unit",
     "test-unit": "mocha -u bdd ./test/*.js"
   },