[IDP-1499] Remove invalid string rule (#20)

* Remove invalid string rule

* Remove test files

---------

Co-authored-by: Mathieu Gamache <[email protected]>

Author: PrincessMadMath

.spectral.yaml

@@ -101,17 +101,6 @@ rules:
       field: type
       function: truthy
 
-  application-json-response-must-not-be-type-string:
-    description: "Responses of type application/json must not be of type string. Having a type:string as a response causes the client generation to fail."
-    recommended: true
-    severity: warn
-    given: $..responses..content..application/json.schema.*
-    then:
-      field: type
-      function: pattern
-      functionOptions:
-        notMatch: 'string'
-
   schema-name-length-must-be-short:
     description: "Schema name must not be too long to support client generation. Current limitation comes from Ruby packages which uses tar and has a limit of 100 characters."
     given: $.components.schemas[*]~

TestSpecs/application-json-response-must-not-be-type-string-invalid.yaml

@@ -8,8 +8,6 @@ spectral --version
 $ruleset = Join-Path $PSScriptRoot ".spectral.yaml"
 
 $tests = @(
-    @{ rule = "application-json-response-must-not-be-type-string"; expectError = $false; filename = "application-json-response-must-not-be-type-string-valid.yaml" },
-    @{ rule = "application-json-response-must-not-be-type-string"; expectError = $true; filename = "application-json-response-must-not-be-type-string-invalid.yaml" },
     @{ rule = "items-must-have-a-type"; expectError = $false; filename = "items-must-have-a-type-valid.yaml" },
     @{ rule = "items-must-have-a-type"; expectError = $true; filename = "items-must-have-a-type-invalid.yaml" },
     @{ rule = "must-accept-content-types"; expectError = $false; filename = "must-accept-content-types-valid.yaml" },