Tweak properties type validation to exclude a property call properties (#16)

Co-authored-by: Mathieu Gamache <[email protected]>

Author: PrincessMadMath

.spectral.yaml

@@ -65,11 +65,20 @@ rules:
         values:
           - oauth2
 
-  properties-must-have-a-type:
-    description: "All properties must have a type."
+  schemas-properties-must-have-a-type:
+    description: "All schemas properties must have a type."
+    recommended: true
+    severity: warn
+    given: $..schemas.*.properties.*
+    then:
+      field: type
+      function: truthy
+
+  path-schema-properties-must-have-a-type:
+    description: "All path schema properties must have a type."
     recommended: true
     severity: warn
-    given: $..properties.*
+    given: $..schema.properties.*
     then:
       field: type
       function: truthy

TestSpecs/properties-must-have-a-type-in-path-invalid.yaml renamed to TestSpecs/path-schema-properties-must-have-a-type-invalid.yaml

@@ -7,4 +7,8 @@ components:
       type: object
       properties:
         sampleProperty:
-          type: string
+          type: string
+        properties:
+          type: object
+          additionalProperties: { }
+          nullable: true

TestSpecs/properties-must-have-a-type-in-path-valid.yaml renamed to TestSpecs/path-schema-properties-must-have-a-type-valid.yaml

@@ -18,10 +18,10 @@ $tests = @(
     @{ rule = "must-return-content-types"; expectError = $true; filename = "must-return-content-types-invalid.yaml" },
     @{ rule = "must-support-client-credentials-oauth2"; expectError = $false; filename = "must-support-client-credentials-oauth2-valid.yaml" },
     @{ rule = "must-support-client-credentials-oauth2"; expectError = $true; filename = "must-support-client-credentials-oauth2-invalid.yaml" },
-    @{ rule = "properties-must-have-a-type"; expectError = $false; filename = "properties-must-have-a-type-in-path-valid.yaml" },
-    @{ rule = "properties-must-have-a-type"; expectError = $false; filename = "properties-must-have-a-type-in-schema-valid.yaml" },
-    @{ rule = "properties-must-have-a-type"; expectError = $true; filename = "properties-must-have-a-type-in-path-invalid.yaml" },
-    @{ rule = "properties-must-have-a-type"; expectError = $true; filename = "properties-must-have-a-type-in-schema-invalid.yaml" },
+    @{ rule = "path-schema-properties-must-have-a-type"; expectError = $false; filename = "path-schema-properties-must-have-a-type-valid.yaml" },
+    @{ rule = "path-schema-properties-must-have-a-type"; expectError = $true; filename = "path-schema-properties-must-have-a-type-invalid.yaml" },
+    @{ rule = "schemas-properties-must-have-a-type"; expectError = $false; filename = "schemas-properties-must-have-a-type-valid.yaml" },
+    @{ rule = "schemas-properties-must-have-a-type"; expectError = $true; filename = "schemas-properties-must-have-a-type-invalid.yaml" },
     @{ rule = "schema-ids-must-have-alphanumeric-characters-only"; expectError = $false; filename = "schema-ids-must-have-alphanumeric-characters-only-valid.yaml" },
     @{ rule = "schema-ids-must-have-alphanumeric-characters-only"; expectError = $true; filename = "schema-ids-must-have-alphanumeric-characters-only-invalid.yaml" },
     @{ rule = "schema-object-must-have-a-type"; expectError = $false; filename = "schema-object-must-have-a-type-valid.yaml" },