Skip to content

Commit ab9ad62

Browse files
authored
Install forked crossenv on all images (#59)
- Running into problems with renaming wheels with auditwheel
1 parent 8f08fc7 commit ab9ad62

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

cross-ubuntu-py/Dockerfile.py311

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ ARG EXTRA_CROSSENV_ARGS=
9292

9393
RUN set -xe; \
9494
ldconfig; \
95-
python3.11 -m pip install crossenv==1.5.0; \
95+
python3.11 -m pip install https://github.com/virtuald/crossenv/archive/2d59977e9e4efa7e4cb22ca7ba81f8a12c36574b.zip; \
9696
python3.11 -m crossenv /build/crosspy/bin/python3.11 /build/venv --sysroot=$(${TARGET_HOST}-print-sysroot) --env UNIXCONFDIR=/build/venv/cross/etc ${EXTRA_CROSSENV_ARGS}; \
9797
/build/venv/bin/cross-pip install wheel;
9898

cross-ubuntu-py/Dockerfile.py312

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ ARG EXTRA_CROSSENV_ARGS=
9898

9999
RUN set -xe; \
100100
ldconfig; \
101-
python3.12 -m pip install 'crossenv~=1.5.0'; \
101+
python3.12 -m pip install https://github.com/virtuald/crossenv/archive/2d59977e9e4efa7e4cb22ca7ba81f8a12c36574b.zip; \
102102
python3.12 -m crossenv /build/crosspy/bin/python3.12 /build/venv ${MACHINE_ARG} --sysroot=$(${TARGET_HOST}-gcc -print-sysroot) --env UNIXCONFDIR=/build/venv/cross/etc ${EXTRA_CROSSENV_ARGS}; \
103103
/build/venv/bin/cross-pip install wheel;
104104

cross-ubuntu-py/Dockerfile.py313

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ ARG EXTRA_CROSSENV_ARGS=
100100

101101
RUN set -xe; \
102102
ldconfig; \
103-
python3.13 -m pip install https://github.com/virtuald/crossenv/archive/patch-pip-packaging-tags.zip; \
103+
python3.13 -m pip install https://github.com/virtuald/crossenv/archive/2d59977e9e4efa7e4cb22ca7ba81f8a12c36574b.zip; \
104104
python3.13 -m crossenv /build/crosspy/bin/python3.13 /build/venv ${MACHINE_ARG} --sysroot=$(${TARGET_HOST}-gcc -print-sysroot) --env UNIXCONFDIR=/build/venv/cross/etc ${EXTRA_CROSSENV_ARGS}; \
105105
/build/venv/bin/cross-pip install wheel;
106106

cross-ubuntu-py/py.mk

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,15 @@ build/cross-python: build/cross-raspbian-py311 build/cross-raspbian-py312 build/
2727
push/cross-python: push/cross-raspbian-py311 push/cross-raspbian-py312 push/cross-roborio-py313 push/cross-systemcore-py313 push/cross-raspbian-py313
2828

2929

30+
# raspbian manylinux tags for crossenv
31+
RPI_ML_VERSIONS := $(shell seq 36 -1 17)
32+
RPI_MANYLINUX_TAGS := $(foreach v,$(SC_ML_VERSIONS),--platform-tag=manylinux_2_$(v)_armv7l)
33+
34+
# systemcore manylinux tags for crossenv
35+
SC_ML_VERSIONS := $(shell seq 35 -1 17)
36+
SC_MANYLINUX_TAGS := $(foreach v,$(SC_ML_VERSIONS),--platform-tag=manylinux_2_$(v)_aarch64)
37+
38+
3039
#
3140
# Python 3.11
3241
#
@@ -40,6 +49,7 @@ build/cross-raspbian-py311:
4049
--build-arg TARGET_HOST=$(TARGET_HOST_RASPBIAN) \
4150
--build-arg AC_TARGET_HOST=$(AC_TARGET_HOST_RASPBIAN) \
4251
--build-arg VERSION=$(VERSION_RASPBIAN) \
52+
--build-arg EXTRA_CROSSENV_ARGS="$(RPI_MANYLINUX_TAGS) --platform-tag=linux_armv7l" \
4353
-f Dockerfile.py311
4454

4555
cd cross-ubuntu-py && \
@@ -68,6 +78,7 @@ build/cross-raspbian-py312:
6878
--build-arg TARGET_HOST=$(TARGET_HOST_RASPBIAN) \
6979
--build-arg AC_TARGET_HOST=$(AC_TARGET_HOST_RASPBIAN) \
7080
--build-arg VERSION=$(VERSION_RASPBIAN) \
81+
--build-arg EXTRA_CROSSENV_ARGS="$(RPI_MANYLINUX_TAGS) --platform-tag=linux_armv7l" \
7182
-f Dockerfile.py312
7283

7384
cd cross-ubuntu-py && \
@@ -97,6 +108,7 @@ build/cross-raspbian-py313:
97108
--build-arg AC_TARGET_HOST=$(AC_TARGET_HOST_RASPBIAN) \
98109
--build-arg VERSION=$(VERSION_RASPBIAN) \
99110
--build-arg EXTRA_CROSS_CONFIGURE_ARGS="ac_cv_libatomic_needed=yes" \
111+
--build-arg EXTRA_CROSSENV_ARGS="$(RPI_MANYLINUX_TAGS) --platform-tag=linux_armv7l" \
100112
-f Dockerfile.py313
101113

102114
cd cross-ubuntu-py && \
@@ -130,10 +142,6 @@ push/cross-roborio-py313:
130142
docker push wpilib/$(TYPE_ROBORIO)-cross-ubuntu:$(YEAR)-$(UBUNTU)-py313
131143

132144

133-
# Adding the tags, but pip ignores them because of https://github.com/benfogle/crossenv/issues/126
134-
SC_ML_VERSIONS := $(shell seq 35 -1 17)
135-
SC_MANYLINUX_TAGS := $(foreach v,$(SC_ML_VERSIONS),--platform-tag=manylinux_2_$(v)_aarch64)
136-
137145

138146
.PHONY: build/cross-systemcore-py313
139147
build/cross-systemcore-py313:

0 commit comments

Comments
 (0)