Skip to content

Commit efadd87

Browse files
committed
Small fixes [release]
1 parent 5f67106 commit efadd87

File tree

5 files changed

+23
-19
lines changed

5 files changed

+23
-19
lines changed

app/src/main/java/io/xpipe/app/browser/file/BrowserFileTransferOperation.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -383,11 +383,12 @@ private void transfer(
383383

384384
var fileSize = sourceFs.getFileSize(sourceFile);
385385

386-
updateProgress(new BrowserTransferProgress(sourceFile.getFileName(), 0, 0));
387-
if (targetFs.writeInstantIfPossible(sourceFs, sourceFile, targetFile) || sourceFs.readInstantIfPossible(sourceFile, targetFs, targetFile)) {
388-
updateProgress(BrowserTransferProgress.finished(sourceFile.getFileName(), fileSize));
389-
return;
390-
}
386+
// TODO: this is not ready yet
387+
// updateProgress(new BrowserTransferProgress(sourceFile.getFileName(), 0, 0));
388+
// if (targetFs.writeInstantIfPossible(sourceFs, sourceFile, targetFile) || sourceFs.readInstantIfPossible(sourceFile, targetFs, targetFile)) {
389+
// updateProgress(BrowserTransferProgress.finished(sourceFile.getFileName(), fileSize));
390+
// return;
391+
// }
391392

392393
InputStream inputStream = null;
393394
OutputStream outputStream = null;

app/src/main/java/io/xpipe/app/pwman/BitwardenPasswordManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ public synchronized CredentialResult retrieveCredentials(String key) {
112112
.readTree(sc.command(cmd).sensitive().readStdoutOrThrow());
113113
var login = json.get("login");
114114
if (login == null) {
115-
throw new IllegalArgumentException("No usable login found for item name " + key);
115+
throw ErrorEventFactory.expected(
116+
new IllegalArgumentException("No usable login found for item name " + key));
116117
}
117118

118119
var user = login.required("username");

app/src/main/java/io/xpipe/app/pwman/KeeperPasswordManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private String getExecutable(ShellControl sc) {
4040
@Override
4141
public synchronized CredentialResult retrieveCredentials(String key) {
4242
// The copy UID button copies the whole URL in the Keeper UI. Why? ...
43-
key = key.replace("https://keepersecurity.eu/vault/#detail/", "");
43+
key = key.replaceFirst("https://keepersecurity\\.\\w+/vault/#detail/", "");
4444

4545
try {
4646
CommandSupport.isInLocalPathOrThrow("Keeper Commander CLI", "keeper");

dist/changelog/19.2_incremental.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1-
- Fix local file system and SFTP speeds being slow due to wrong buffer sizes
2-
- Fix SFTP open browser menu option not showing for VMs
3-
- Fix file browser context menu not closing on keyboard shortcut (Thanks for @nillpoe for the PR)
1+
- Re-enable AVX optimizations as much as possible without causing crashes
2+
- You can now also filter for connection type / connection information like the os name
3+
- Add Ctrl+F shortcut to focus search field
4+
- There is now a warning when you type into a password field and capslock is active
45
- Fix RDP client setting not persisting
5-
- Fix SSH PKCS11 Provider option breaking on systems with very old SSH client
6-
- Fix GNU tools (e.g. from homebrew or nix) on macOS breaking some file browser features
6+
- Fix SSH PKCS11Provider option breaking on systems with very old SSH client
7+
- Fix GNU tools on macOS (e.g. from homebrew or nix) breaking some file browser features
78
- Fix file browser drag hover trying to cd into files as well
89
- Fix RDP tunnel connections not automatically taking credentials from parent entry
9-
- Fix connection timeout not taking password prompts and others into consideration in v19
10-
- Fix Keeper password manager error messages not being shown
11-
- Fix Keeper record URLs not being accepted
12-
- Fix autoupdater download breaking with dashes in username on Windows
10+
- Fix file browser context menu not closing on keyboard shortcut (Thanks for @nillpoe for the PR)
11+
- Fix connection timeout not taking password prompts and others into consideration
12+
- Fix local file system speeds being slow due to wrong buffer sizes
13+
- Fix some Keeper password manager error messages not being shown
14+
- Fix full Keeper record URLs not being accepted
15+
- Fix SFTP open browser menu option not showing for VMs
16+
- Fix auto-updater download breaking with dashes in username on Windows
1317
- Fix issues when opening terminal for a fish v4 login shell
1418
- Fix integrated VNC client failing to start when shell connection was not possible
1519
- Fix some issues with VNC handling for libvirt VMs
16-
- You can now also filter for connection type / connection information like the os name
17-
- Add Ctrl+F shortcut to focus search field
1820
- Fix various NullPointers

version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2-4
1+
19.2

0 commit comments

Comments
 (0)