Make sure nullable arguments are strongly typed with null type (#163)

Author: J-Ben87

.led/scripts/tests

@@ -14,7 +14,7 @@ $composer = \array_filter(\explode(\PHP_EOL, $action['runs']['steps'][1]['run'])
 
 $io = new SymfonyStyle(new ArrayInput([]), new ConsoleOutput());
 
-$execute = function (array $job, string $php = null, string $symfony = null) use ($io, $composer) {
+$execute = function (array $job, string|null $php = null, string|null $symfony = null) use ($io, $composer) {
     $io->section($job['name']);
 
     if ($php === null && $symfony === null) {

src/batch-doctrine-dbal/src/DoctrineDBALInsertWriter.php

@@ -21,7 +21,7 @@ final class DoctrineDBALInsertWriter implements ItemWriterInterface
     public function __construct(
         ConnectionRegistry $doctrine,
         private string $table,
-        string $connection = null,
+        string|null $connection = null,
     ) {
         $connection ??= $doctrine->getDefaultConnectionName();
         /** @var Connection $connection */

src/batch-doctrine-dbal/src/DoctrineDBALQueryCursorReader.php

@@ -34,7 +34,7 @@ public function __construct(
         private string $sql,
         private string $column,
         private mixed $start,
-        string $connection = null,
+        string|null $connection = null,
         private int $batch = 500,
     ) {
         if (!\str_contains($sql, '{after}') || !\str_contains($sql, '{limit}')) {

src/batch-doctrine-dbal/src/DoctrineDBALQueryOffsetReader.php

@@ -21,8 +21,12 @@ final class DoctrineDBALQueryOffsetReader implements ItemReaderInterface
     private string $sql;
     private int $batch;
 
-    public function __construct(ConnectionRegistry $doctrine, string $sql, string $connection = null, int $batch = 500)
-    {
+    public function __construct(
+        ConnectionRegistry $doctrine,
+        string $sql,
+        string|null $connection = null,
+        int $batch = 500,
+    ) {
         if (\mb_strpos($sql, '{limit}') === false || \mb_strpos($sql, '{offset}') === false) {
             throw new InvalidArgumentException(
                 \sprintf('%s $sql argument must contains "{limit}" and "{offset}" for pagination.', __METHOD__),

src/batch-doctrine-dbal/src/DoctrineDBALUpsertWriter.php

@@ -25,7 +25,7 @@ final class DoctrineDBALUpsertWriter implements
 
     private Connection $connection;
 
-    public function __construct(ConnectionRegistry $doctrine, string $connection = null)
+    public function __construct(ConnectionRegistry $doctrine, string|null $connection = null)
     {
         $connection ??= $doctrine->getDefaultConnectionName();
         /** @var Connection $connection */

src/batch-doctrine-dbal/src/JobExecutionRowNormalizer.php

@@ -53,7 +53,7 @@ public function toRow(JobExecution $jobExecution): array
      *
      * @param array<string, mixed> $data
      */
-    public function fromRow(array $data, JobExecution $parent = null): JobExecution
+    public function fromRow(array $data, JobExecution|null $parent = null): JobExecution
     {
         $data['status'] = \intval($data['status']);
         $data['parameters'] = $this->jsonFromString($data['parameters']);

src/batch-doctrine-persistence/src/ObjectRegistry.php

@@ -58,7 +58,7 @@ function ($repository) use ($criteria) {
      *
      * @return T|null
      */
-    public function findOneUsing(string $class, \Closure $closure, string $key = null): null|object
+    public function findOneUsing(string $class, \Closure $closure, string|null $key = null): null|object
     {
         $manager = $this->doctrine->getManagerForClass($class);
         if ($manager === null) {

src/batch-doctrine-persistence/tests/Dummy/FindOneByCalledOnlyOnceWhenFoundRepositoryDecorator.php

@@ -25,7 +25,7 @@ public function findAll()
         return $this->decorated->findAll();
     }
 
-    public function findBy(array $criteria, null|array $orderBy = null, $limit = null, $offset = null)
+    public function findBy(array $criteria, array|null $orderBy = null, $limit = null, $offset = null)
     {
         return $this->decorated->findBy($criteria, $orderBy, $limit, $offset);
     }

src/batch-league-flysystem/src/Job/CopyFilesJob.php

@@ -24,7 +24,7 @@ public function __construct(
         private JobParameterAccessorInterface $location,
         private FilesystemReader $source,
         private FilesystemWriter $destination,
-        private null|Closure $transformLocation = null,
+        private Closure|null $transformLocation = null,
     ) {
     }
 

src/batch-league-flysystem/src/Job/MoveFilesJob.php

@@ -25,7 +25,7 @@ public function __construct(
         private JobParameterAccessorInterface $location,
         private FilesystemOperator $source,
         private FilesystemWriter $destination,
-        private null|Closure $transformLocation = null,
+        private Closure|null $transformLocation = null,
     ) {
     }