android: Use Starboard Features for the delay during recreating VideoDecoder (#6849)

Allow to enable configurating the delay between reset/flush VideoDeocder
using Starboard features. Examples are:
-
`'--enable-features=VideoDecoderDelayUsecOverride:ResetDelayUsec/10ms'`
-
`'--enable-features=VideoDecoderDelayUsecOverride:FlushDelayUsec/10ms'`

Issue: 400511693

Author: borongc

starboard/android/shared/player_components_factory.cc

@@ -74,12 +74,6 @@ constexpr bool kForceSecurePipelineInTunnelModeWhenRequired = true;
 // video distortion on some platforms.
 constexpr bool kForceResetSurfaceUnderTunnelMode = true;
 
-// By default, Cobalt restarts MediaCodec after stops/flushes during
-// Reset()/Flush(). Set the following variable to > 0 to force it to
-// wait during Reset()/Flush().
-constexpr int64_t kResetDelayUsecOverride = 0;
-constexpr int64_t kFlushDelayUsecOverride = 0;
-
 // This class allows us to force int16 sample type when tunnel mode is enabled.
 class AudioRendererSinkAndroid : public ::starboard::shared::starboard::player::
                                      filter::AudioRendererSinkImpl {
@@ -502,8 +496,8 @@ class PlayerComponentsFactory : public starboard::shared::starboard::player::
     bool force_big_endian_hdr_metadata = false;
     bool enable_flush_during_seek = starboard::features::FeatureList::IsEnabled(
         starboard::features::kForceFlushDecoderDuringReset);
-    int64_t reset_delay_usec = 0;
-    int64_t flush_delay_usec = 0;
+    int64_t flush_delay_usec = starboard::features::kFlushDelayUsec.Get();
+    int64_t reset_delay_usec = starboard::features::kResetDelayUsec.Get();
     // The default value of |force_reset_surface| would be true.
     bool force_reset_surface = true;
     if (creation_parameters.video_codec() != kSbMediaVideoCodecNone &&
@@ -527,16 +521,12 @@ class PlayerComponentsFactory : public starboard::shared::starboard::player::
     SB_LOG_IF(INFO, enable_flush_during_seek)
         << "`kForceFlushDecoderDuringReset` is set to true, force flushing"
         << " video decoder during Reset().";
-    if (kResetDelayUsecOverride > 0) {
-      reset_delay_usec = kResetDelayUsecOverride;
-      SB_LOG(INFO) << "`kResetDelayUsecOverride` is set to > 0, force a delay"
-                   << " of " << reset_delay_usec << "us during Reset().";
-    }
-    if (kFlushDelayUsecOverride > 0) {
-      flush_delay_usec = kFlushDelayUsecOverride;
-      SB_LOG(INFO) << "`kFlushDelayUsecOverride` is set to > 0, force a delay"
-                   << " of " << flush_delay_usec << "us during Flush().";
-    }
+    SB_LOG_IF(INFO, flush_delay_usec > 0)
+        << "`kFlushDelayUsec` is set to > 0, force a delay of "
+        << flush_delay_usec << "us during Flush().";
+    SB_LOG_IF(INFO, reset_delay_usec > 0)
+        << "`kResetDelayUsec` is set to > 0, force a delay of "
+        << reset_delay_usec << "us during Reset().";
 
     auto video_decoder = std::make_unique<VideoDecoder>(
         creation_parameters.video_stream_info(),

starboard/extension/feature_config.h

@@ -110,6 +110,15 @@ STARBOARD_FEATURE(kForceFlushDecoderDuringReset,
 // Set the following variable to true to force it reset audio decoder
 // during Reset(). This should be enabled with kForceFlushDecoderDuringReset.
 STARBOARD_FEATURE(kForceResetAudioDecoder, "ForceResetAudioDecoder", false)
+
+// By default, Cobalt restarts MediaCodec after stops/flushes during
+// Reset()/Flush(). Set the following variable to true with parameters
+// kResetDelayUsec and kFlushDelayUsec to force it to wait during
+// Reset()/Flush(). For example, with args
+// '--enable-features=VideoDecoderDelayUsecOverride:ResetDelayUsec/10ms'.
+STARBOARD_FEATURE(kVideoDecoderDelayUsecOverride,
+                  "VideoDecoderDelayUsecOverride",
+                  false)
 #endif  // BUILDFLAG(IS_ANDROID) && (SB_API_VERSION >= 17)
 FEATURE_LIST_END
 
@@ -172,4 +181,20 @@ FEATURE_PARAM_LIST_START
 //                           "CobaltDebugSetting",
 //                           "standard")
 // #endif // BUILDFLAG(IS_ANDROID) && (SB_API_VERSION >= 17)
+
+#if BUILDFLAG(IS_ANDROID) && (SB_API_VERSION >= 17)
+// By default, Cobalt restarts MediaCodec after stops/flushes during
+// Reset()/Flush(). Set the following variable to > 0 to force it to
+// wait during Reset()/Flush().
+STARBOARD_FEATURE_PARAM(STARBOARD_FEATURE_PARAM_TIME_TYPE,
+                        kFlushDelayUsec,
+                        kVideoDecoderDelayUsecOverride,
+                        "FlushDelayUsec",
+                        base::Microseconds(0))
+STARBOARD_FEATURE_PARAM(STARBOARD_FEATURE_PARAM_TIME_TYPE,
+                        kResetDelayUsec,
+                        kVideoDecoderDelayUsecOverride,
+                        "ResetDelayUsec",
+                        base::Microseconds(0))
+#endif  // BUILDFLAG(IS_ANDROID) && (SB_API_VERSION >= 17)
 FEATURE_PARAM_LIST_END