Replace fest with assertj (facebook#32770)

Summary:
Pull Request resolved: facebook#32770

Fest is EOL and is replaced by assertj, originally a fork of Fest. This change replaces the usages in internal tests and removes the dependency.

Changelog:
[Internal][Android] Replace fest with assertj

Reviewed By: genkikondo

Differential Revision: D33143454

fbshipit-source-id: c1cbe5b064d007018f73858b2913806c11aa08af

Author: Andrei Shikov

ReactAndroid/build.gradle

@@ -380,7 +380,7 @@ dependencies {
     testImplementation("org.powermock:powermock-module-junit4-rule:${POWERMOCK_VERSION}")
     testImplementation("org.powermock:powermock-classloading-xstream:${POWERMOCK_VERSION}")
     testImplementation("org.mockito:mockito-core:${MOCKITO_CORE_VERSION}")
-    testImplementation("org.easytesting:fest-assert-core:2.0M10")
+    testImplementation("org.assertj:assertj-core:3.21.0")
     testImplementation("org.robolectric:robolectric:${ROBOLECTRIC_VERSION}")
 
     androidTestImplementation(fileTree(dir: "src/main/third-party/java/buck-android-support/", include: ["*.jar"]))

ReactAndroid/src/androidTest/java/com/facebook/react/tests/core/BUCK

@@ -14,7 +14,7 @@ rn_android_library(
     is_androidx = True,
     deps = [
         react_native_dep("third-party/android/androidx:test-espresso-core"),
-        react_native_dep("third-party/java/fest:fest"),
+        react_native_dep("third-party/java/assertj:assertj-core"),
         react_native_dep("third-party/java/junit:junit"),
         react_native_dep("third-party/android/androidx:test-rules"),
         react_native_dep("third-party/android/androidx:test-runner"),

ReactAndroid/src/androidTest/java/com/facebook/react/tests/core/ReactRootViewTest.java

@@ -7,7 +7,7 @@
 
 package com.facebook.react.tests.core;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 import android.app.Instrumentation;
 import android.view.View;

ReactAndroid/src/androidTest/java/com/facebook/react/tests/core/WritableNativeMapTest.java

@@ -7,7 +7,7 @@
 
 package com.facebook.react.tests.core;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 import androidx.test.runner.AndroidJUnit4;
 import com.facebook.react.bridge.NoSuchKeyException;

ReactAndroid/src/main/third-party/java/assertj/BUCK

@@ -0,0 +1,14 @@
+load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
+load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
+
+rn_prebuilt_jar(
+    name = "assertj-core",
+    binary_jar = ":assertj-core.jar",
+    visibility = ["//ReactAndroid/..."],
+)
+
+fb_native.remote_file(
+    name = "assertj-core.jar",
+    sha1 = "27a14d6d22c4e3d58f799fb2a5ca8eaf53e6942a",
+    url = "mvn:org.assertj:assertj-core:jar:3.21.0",
+)

ReactAndroid/src/main/third-party/java/fest/BUCK

@@ -11,7 +11,7 @@ rn_robolectric_test(
         react_native_dep("third-party/android/androidx:fragment"),
         react_native_dep("third-party/android/androidx:legacy-support-core-ui"),
         react_native_dep("third-party/android/androidx:legacy-support-core-utils"),
-        react_native_dep("third-party/java/fest:fest"),
+        react_native_dep("third-party/java/assertj:assertj-core"),
         react_native_dep("third-party/java/jsr-305:jsr-305"),
         react_native_dep("third-party/java/junit:junit"),
         react_native_dep("third-party/java/okhttp:okhttp3"),

ReactAndroid/src/test/java/com/facebook/react/BUCK

@@ -7,7 +7,7 @@
 
 package com.facebook.react;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.mock;

ReactAndroid/src/test/java/com/facebook/react/RootViewTest.java

@@ -8,7 +8,7 @@ rn_robolectric_test(
         "PUBLIC",
     ],
     deps = [
-        react_native_dep("third-party/java/fest:fest"),
+        react_native_dep("third-party/java/assertj:assertj-core"),
         react_native_dep("third-party/java/jsr-305:jsr-305"),
         react_native_dep("third-party/java/junit:junit"),
         react_native_target("java/com/facebook/react:react"),

ReactAndroid/src/test/java/com/facebook/react/animated/BUCK

@@ -7,7 +7,7 @@
 
 package com.facebook.react.animated;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;