-
Notifications
You must be signed in to change notification settings - Fork 69
Improve Zulipbot messages #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 64.37% 64.37%
=======================================
Files 23 23
Lines 1763 1763
=======================================
Hits 1135 1135
Misses 628 628 🚀 New features to boost your workflow:
|
|
These changes all seem like improvements, thanks for doing this! |
|
I pushed an update addressing all the feedback above. We may want to hold off on merging the last commit (403ec2f) until we also have a fix to check for double assignments at the right time, as it's expected to make that possibility come up more often. |
|
I merged the first 4 commits as the series ending with 36b0fe1. |
|
I was recently reminded of the text of our new contributor Zulipbot messages, and at this point I don't think it's worth waiting for technical changes before we make some improvements. @timabbott would you be comfortable with merging the last commit on this PR? Or maybe we can tweak it a bit to specifically address double assignments, e.g.: "You can contribute by providing feedback on their pull request." -> "You can unassign yourself and contribute by providing feedback on their pull request." |
|
Yeah I think a tweak of that form is probably a reasonable option. |
The goal here is to encourage folks not to claim an issue until they are ready. We're counting on the contributor not to accept the GitHub invite until ready, which is not ideal because (a) they might just accept it, and (b) there's a risk that the invite will expire. So we'd probably be better off splitting this into two interactions (joining repo; claiming issue). This also shortens the message if the initial invite hasn't been accepted.
|
Rebased and updated the changes. |
|
Merged, thanks @alya! |
I generally tried to make the language Zulipbot uses clear but more succinct than it currently is, with links to documentation where relevant.
There are no logic changes, and all the variables used were already in the comment.
This PR also adds a checklist for brand new contributors, to encourage claiming the first issue only when ready. As described in the commit message, I think the way this is implemented here (with no logic changes) is not ideal. But we could try it and see how it goes.
I don't know how to test these changes.