Skip to content

Conversation

@alya
Copy link
Contributor

@alya alya commented Apr 15, 2022

I generally tried to make the language Zulipbot uses clear but more succinct than it currently is, with links to documentation where relevant.

There are no logic changes, and all the variables used were already in the comment.

This PR also adds a checklist for brand new contributors, to encourage claiming the first issue only when ready. As described in the commit message, I think the way this is implemented here (with no logic changes) is not ideal. But we could try it and see how it goes.

I don't know how to test these changes.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.37%. Comparing base (7dc7e37) to head (1d20911).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   64.37%   64.37%           
=======================================
  Files          23       23           
  Lines        1763     1763           
=======================================
  Hits         1135     1135           
  Misses        628      628           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timabbott
Copy link
Member

These changes all seem like improvements, thanks for doing this!

@alya
Copy link
Contributor Author

alya commented Apr 18, 2022

I pushed an update addressing all the feedback above.

We may want to hold off on merging the last commit (403ec2f) until we also have a fix to check for double assignments at the right time, as it's expected to make that possibility come up more often.

@timabbott
Copy link
Member

I merged the first 4 commits as the series ending with 36b0fe1.

@alya
Copy link
Contributor Author

alya commented Oct 13, 2022

I was recently reminded of the text of our new contributor Zulipbot messages, and at this point I don't think it's worth waiting for technical changes before we make some improvements.

@timabbott would you be comfortable with merging the last commit on this PR? Or maybe we can tweak it a bit to specifically address double assignments, e.g.:

"You can contribute by providing feedback on their pull request." -> "You can unassign yourself and contribute by providing feedback on their pull request."

@timabbott
Copy link
Member

Yeah I think a tweak of that form is probably a reasonable option.

The goal here is to encourage folks not to claim an issue until they
are ready.

We're counting on the contributor not to accept the GitHub invite until
ready, which is not ideal because (a) they might just accept it, and
(b) there's a risk that the invite will expire. So we'd probably be better
off splitting this into two interactions (joining repo; claiming issue).

This also shortens the message if the initial invite hasn't been accepted.
@alya
Copy link
Contributor Author

alya commented Nov 18, 2025

Rebased and updated the changes.

@timabbott timabbott merged commit e77b7e7 into zulip:main Nov 21, 2025
4 checks passed
@timabbott
Copy link
Member

Merged, thanks @alya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants