use find_by in active_profile #12251
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
this PR changes
active_profilein theusermodel to usefind_by, which should be faster. I tested my changes on my machine with a test user with four profiles and the difference was 0.449454 seconds against 0.235338 seconds. it also moves the@active_profilecheck to where profiles are deactivated by reloading the user model rather than calling.active, which might have been useless (if the code checks a user with a falseactive_profileand assigned@active_profilebased on the in-memory query,@active_profilewould becomenilanddefined?(@active_profile)would be true, but.activewould benil, bypassing the check)