(bug) update bucket logic, existing user logic, and specs #12684
+176
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guruparan18
approved these changes
Dec 2, 2025
Contributor
guruparan18
left a comment
guruparan18
left a comment
There was a problem hiding this comment.
Looks good to me. Ran tests with couple of partners to verify the data and the fix.
changelog: internal, reporting, billing report v2 updates
MrNagoo
force-pushed
the
331/billing-report-rollup-discrepancies
branch
from
262828a to
78051c9
Compare
guruparan18
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: internal, reporting, billing report v2 updates
🛠 Summary of changes
Fix an issue where globally checking a user_id would cause improper aggregate statistics.