Add tests for state management #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-test-for-state-management
…e-test-for-state-management
JillRegan
changed the title
volodymyrZotov
approved these changes
Dec 2, 2025
| var testItems = map[op.ItemCategory]testItem{ | ||
| op.Login: { | ||
| var testItems = map[model.ItemCategory]testItem{ | ||
| model.Login: { |
Contributor
There was a problem hiding this comment.
Let's also update op.Vault in internal/provider/onepassword_vault_data_source_test.go
Contributor
Author
There was a problem hiding this comment.
I actually have a PR open as I found several other spots where we still reference connect data instead of new models. In that I update internal/provider/onepassword_vault_data_source_test.go 👍
JillRegan
merged commit 89263ae
into
feature/configure-provider-to-use-sdk
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
🔗 Resolves:
✅ Checklist
🕵️ Review Notes &⚠️ Risks