Sarahb fizzbuzz #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
models/sarahb_fizzbuzz.rb
Outdated
|
|
||
| def string | ||
| x = @fizzbuzz | ||
| if x % 3 == 0 && x % 5 == 0 |
There was a problem hiding this comment.
change to a case statement rather than if/elsif.
Perhaps move the % == 0 tests outside the case statement - set as a variable and then check if the variable is true/false inside the case statement. Means you'll only be performing each % check once rather than potentially twice
lillypiri
reviewed
Mar 27, 2017
models/sarahb_fizzbuzz.rb
Outdated
| def string | ||
| x = @fizzbuzz | ||
| if x % 3 == 0 && x % 5 == 0 | ||
| return "fizzbuzz" |
There was a problem hiding this comment.
Great code! Do you need to have 'return' written here?
nigelr
requested changes
Mar 27, 2017
|
|
||
| end | ||
|
|
||
| puts Fizzbuzz.new(15).string |
| fb = Fizzbuzz.new(15) | ||
| expect(fb.string).to eq('fizzbuzz') | ||
| end | ||
|
|
| @@ -1 +1 @@ | |||
| 2.4 | |||
| 2.4.0 | |||
Member
There was a problem hiding this comment.
try not to change these files in a feature change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.