Add namespaces to build.gradle for AGP8+ support #28
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When i tried to run my app with Torch Controller installed on Android. I got a 'Namespace not specified for AGP 8.0.0' error during building phase after upgrading AGP to 8.0+. This is because AGP 8.0+ have a breaking changes that required namespace in the module-level build script.
I also removed package attributes in AndroidManifest to prevent
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.error during build phase. Feel free to edit your own namespaces before updating your package in pub.dev.I also added JVM toolchain compatibility.
Tested on my app using OPPO Reno 5 Pro (API 33) and Android API 34 emulator.
Developer checklist
Breaking Change
Does your PR require users to manually update their apps to accommodate your change?
Minor Change
Does your PR does significant semantic change? (A lot of design changes, architecture changes...)
For reviewers
All PR's needs at least one reviewer to be merged.
Before merge this PR confirm that it meets all requirements listed below: