Skip to content

Conversation

@famasf1
Copy link

@famasf1 famasf1 commented Apr 11, 2024

Description

When i tried to run my app with Torch Controller installed on Android. I got a 'Namespace not specified for AGP 8.0.0' error during building phase after upgrading AGP to 8.0+. This is because AGP 8.0+ have a breaking changes that required namespace in the module-level build script.

I also removed package attributes in AndroidManifest to prevent Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. error during build phase. Feel free to edit your own namespaces before updating your package in pub.dev.

I also added JVM toolchain compatibility.

Tested on my app using OPPO Reno 5 Pro (API 33) and Android API 34 emulator.

Developer checklist

  • All existing and new tests are passing.
  • All github actions are passing.

Breaking Change

Does your PR require users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Minor Change

Does your PR does significant semantic change? (A lot of design changes, architecture changes...)

  • Yes, this is a minor change.
  • No, this is not a minor change.

For reviewers

All PR's needs at least one reviewer to be merged.

Before merge this PR confirm that it meets all requirements listed below:

  • The PR has good quality code and has automated tests (if is the case)
  • This PR is not as Draft

@famasf1 famasf1 changed the title Add namespaces to AndroidManifest for AGP8+ support Add namespaces to build.gradle for AGP8+ support Apr 11, 2024
@famasf1 famasf1 marked this pull request as ready for review April 11, 2024 03:55
@lovelessX
Copy link
Contributor

AGP 8.0+ is now the default for new Flutter projects, so this makes this very difficult to use this package. Can we get this looked at and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants