Clean up TODOs in baby_fuzzers #3547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The 2 failing checks are unrelated to the changes I made. My changes are purely related to baby_fuzzers which all passed. What could the issue be? |
Contributor
Author
|
It seems those 2 checks are also failing on other recent and merged PRs. |
domenukk
reviewed
Nov 24, 2025
fuzzers/baby/baby_fuzzer/src/main.rs
Outdated
| // TODO: This will break soon, fix me! See https://github.com/AFLplusplus/LibAFL/issues/2786 | ||
| #[allow(static_mut_refs)] // only a problem in nightly | ||
| let observer = unsafe { StdMapObserver::from_mut_ptr("signals", SIGNALS_PTR, SIGNALS.len()) }; | ||
| let observer = unsafe { StdMapObserver::from_mut_ptr("signals", SIGNALS_PTR, SIGNALS_LEN) }; |
Member
There was a problem hiding this comment.
It would be better if these used ConstMapOververs, see this discussion:
#2770 (comment)
Contributor
Author
There was a problem hiding this comment.
I couldn't implement ConstMapObserver in baby_fuzzer_swap_differential but I implemented it into the rest of the files I changed
Contributor
Author
|
The third test case that failed here (other than the 2 that were already failing) also failed on the latest commit pushed to the repo |
Member
|
Awesome, thank you! Yes the failing testcases are due to a Rust update, not this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1907, this PR addresses the TODOs present in the baby_fuzzers. I'm still new to open source contributions, but I think I did all pre-flight checks from CONTRIBUTING.md. If there's anything I can improve, let me know. Thank you!