Added mypy configs and fixed all errors (S.R No. 24) #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is still work in progress as their 171 errors are their so it may take time along with my mid sem exams. So please dont merge |
Rishab87
changed the title
Member
|
reminder to take a fresh pull, while working* |
Contributor
Author
|
Yes I'll take a fresh pull, thanks! |
Contributor
Author
|
I was able to find few issues with recently added pydantic models with mypy, fixing them too here. |
Rishab87
changed the title
Contributor
Author
|
Its ready to be reviewed |
Contributor
Author
|
@Pranav0-0Aggarwal can you please review it? |
Contributor
Author
|
@Pranav0-0Aggarwal just a follow up, can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mypy configs and fix all 171 errors ensuring high maintainability and code quality. It also adds this check to pre commit hook.
Fixes #381