Skip to content

#65: Smart layout switching #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

#65: Smart layout switching #82

wants to merge 10 commits into from

Conversation

@shubertm
Copy link
Member

@shubertm shubertm commented Aug 20, 2023 •
edited by kirillt
Loading

@shubertm shubertm requested review from kirillt and mdrlzy August 20, 2023 10:37
@shubertm
Merge remote-tracking branch 'origin/main' into smart-layout
2dbf88d 
# Conflicts:
#	app/src/main/java/space/taran/arkretouch/presentation/edit/EditViewModel.kt
@shubertm
Fix plain layout
4f5ff76
@shubertm shubertm temporarily deployed to Development August 21, 2023 11:40 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 21, 2023 11:43 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 21, 2023 11:43 — with GitHub Actions Inactive
@kirillt
Copy link
Member

kirillt commented Sep 7, 2023 •
edited
Loading

  • Automatic mode: sometimes after layout switch the image "jumps" back
  • Manual mode: the dialog is a bit annoying, we should invent how to ask user without breaking his train of thought. Maybe create switch button in a corner and highlight it when it's possible to switch?

@shubertm shubertm temporarily deployed to Development September 10, 2023 19:33 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 10, 2023 19:39 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 10, 2023 19:39 — with GitHub Actions Inactive
@kirillt
Copy link
Member

kirillt commented Sep 11, 2023

Works really good, only new button lives its own life :)

I think we should remove disappearing by timer.

@shubertm
Copy link
Member Author

shubertm commented Sep 11, 2023

Works really good, only new button lives its own life :)

I think we should remove disappearing by timer.

Alright

@shubertm shubertm temporarily deployed to Development September 12, 2023 19:54 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 12, 2023 19:57 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 12, 2023 19:57 — with GitHub Actions Inactive
This was referenced Sep 13, 2023
Closed
Closed
@shubertm shubertm temporarily deployed to Development September 19, 2023 07:04 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 19, 2023 07:07 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 19, 2023 07:07 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 28, 2023 10:15 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 28, 2023 10:21 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development September 28, 2023 10:21 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillt kirillt Awaiting requested review from kirillt

@mdrlzy mdrlzy Awaiting requested review from mdrlzy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubertm @kirillt