Skip to content

#656 Make offset types exhaustive when matching in SQL generators. #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

#656 Make offset types exhaustive when matching in SQL generators. #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDatabricks.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ class SqlGeneratorDatabricks(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlC
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Databricks SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDb2.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class SqlGeneratorDb2(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig)
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in DB2 SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDenodo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ class SqlGeneratorDenodo(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Denodo SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorGeneric.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class SqlGeneratorGeneric(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConf
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in the generic SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHive.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ class SqlGeneratorHive(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig)
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Hive SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHsqlDb.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class SqlGeneratorHsqlDb(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in HSQLDB SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorMicrosoft.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ class SqlGeneratorMicrosoft(sqlConfig: SqlConfig) extends SqlGenerator {
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in MS SQL Server query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorMySQL.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ class SqlGeneratorMySQL(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in MySQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorOracle.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ class SqlGeneratorOracle(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Oracle SQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorPostgreSQL.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ class SqlGeneratorPostgreSQL(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlC
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in PostgreSQL query generator.")
}
}

Expand Down
2 changes: 2 additions & 0 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorSas.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ class SqlGeneratorSas(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig)
s"$column $condition $value"
case OffsetValue.StringValue(value) =>
s"$column $condition '$value'"
case t =>
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in SAS SQL query generator.")
}
}
}