Adding Format Script #115
Open
Adding Format Script #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessbee
force-pushed
the
ms/update-format
branch
from
e0783df to
de619df
Compare
mujahidkay
reviewed
Jan 10, 2025
Member
mujahidkay
left a comment
mujahidkay
left a comment
There was a problem hiding this comment.
I believe it would also help to add a prettierrc. We can configure it to format jsdoc and shell scripts as well.
| "node_modules" | ||
| ] | ||
| } | ||
| "compilerOptions": { |
Member
There was a problem hiding this comment.
Let's add a prettierignore that ignores all json files except package.json (see this for ref)
Contributor
Author
There was a problem hiding this comment.
Sure. Do we have .prettierrc in any repo that we can copy?
Member
There was a problem hiding this comment.
we take a look at the one in agoric-sdk but its not applicable as is. We can use relevant portions though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.