Fix: Improve light-mode to disable background colors (#4519) #4577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
--light-modeon terminals with light backgrounds, the output is difficult to read due to:This makes aider unusable for users with light-themed terminals, as reported in issue #4519.
Solution
This PR implements a complete fix for light-mode background issues:
Changes Made:
--code-theme-no-backgroundflag: New command-line option to disable background colors in code themes--light-modeis enabled, backgrounds are automatically disabledaider/md_renderer.py): Handles code block rendering with optional background removalaider/theme_utils.py): Centralized theme management and background controlNonein light modeTechnical Implementation:
aider/args.pyto add the--code-theme-no-backgroundargumentaider/main.pyto automatically enable background removal in light-modeaider/io.pyto accept and pass thecode_theme_no_backgroundparameterCustomMarkdownclass that extends Rich's Markdown with background controlaider/mdstream.pyto use the new custom rendererTesting:
--light-modeflag on light-themed terminals