Skip to content

Conversation

@relliky
Copy link

@relliky relliky commented May 8, 2024

@AlexxIT think you had a different interpertation of data of the knob event this device reports when you converts to the new format. I have rewrote it (the chip does not support more than 4 buttons so the developer to override the rotation data and encode 8 button actions into it). Please see comments in the code for details.

Feel free to streamline the code or the event name if we can make it shorter without being hard to undersrtand.

@AlexxIT AlexxIT self-assigned this May 12, 2024
@relliky
Copy link
Author

relliky commented May 29, 2024

@AlexxIT please let me know if there is any concerns on this PR.

The PR has been working very well for me for the last few weeks. And I also put an article in Chinese that share my experience around this device in a Chinese Home Assistant forum https://bbs.hassbian.com/thread-25298-1-1.html with a video demo there.

@AlexxIT
Copy link
Owner

AlexxIT commented May 29, 2024

Sorry. Haven't looked at it yet. So many other projects.

@WalterDSU
Copy link

good to know, thx.

@relliky
Copy link
Author

relliky commented Jan 1, 2025

It has been 8 months since I raised this PR. Is there anything I can help to get this merged?

@AlexxIT
Copy link
Owner

AlexxIT commented Jan 2, 2025

Not an elegant solution, although it works. Huge number of action values.
It is better to write a personal converter for this parameter, which will split this message into button, direction, etc.
Like with locks https://github.com/AlexxIT/XiaomiGateway3/wiki/Handle-BLE-Locks
I had planned to do this when I had time, but forgot about this PR.

@AlexxIT AlexxIT force-pushed the master branch 3 times, most recently from 007adde to a1ab25b Compare July 27, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants