add helm hooks to properly upgrade CRDs in Helm chart without manual updates and without separate Helm chart #1862
Conversation
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <[email protected]>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <[email protected]>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <[email protected]>
…helm_chart.sh, remove duplicated strategy from Deployment-clickhouse-operator.yaml
Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
… improve_helm Signed-off-by: Slach <[email protected]> # Conflicts: # deploy/helm/clickhouse-operator/values.schema.json
| # Cleanup | ||
| cd / | ||
| rm -rf "$TEMP_DIR" | ||
| name: release_chart |
There was a problem hiding this comment.
weird, this is looks like line endings changed, but i didn't
file identical
| } | ||
| } | ||
| } | ||
| { |
There was a problem hiding this comment.
the same, i have LF line endings here, maybe on github it CRLF
Signed-off-by: Slach <[email protected]>
|
root reason why check_helm fails |
I believe that under the new repo the chart name is |
|
@joshleecreates images just not published yet, this is root reason, i install helm from local directory |
Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]> # Conflicts: # .gitignore
Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
|
ok. check helm passed, ready to merge |
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.