Fix infinite scroll bugs: clickable items and page reload #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various dependencies have been updated to their latest versions in package-lock.json, including @InQuirer, @radix-ui, @types/node, @WordPress, and axios packages. This ensures compatibility, security, and access to new features and bug fixes.
- Remove excerptField from imports and fields array - Remove unused enforceContentExcerptMutualExclusion import - Content remains in default view fields
- Delete src/social-web/components/fields/excerpt/ directory - Remove excerpt export from fields index - Keep excerpt data in types and hooks for content field fallback logic
Resolved merge conflicts: - includes/functions.php: Added Mention type handling from trunk - includes/rest/class-inbox-controller.php: Updated get_local_recipients to use Following::get_follower_ids for public activities - package.json: Merged dependency updates from trunk with Reader UI deps - package-lock.json: Regenerated with npm install
Replaces usage of '_activitypub_followers' with '_activitypub_followed_by' in test cases to match updated follower tracking. Also improves the test for activities with no recipients to ensure only followers receive public activities, and adds setup/cleanup for actor mode and remote actor mocking.
pfefferle
force-pushed
the
fix/infinite-scroll-bugs
branch
2 times, most recently
from
07e38f3 to
da0ffbe
Compare
- Remove isLoadingMore from isLoading prop so items remain clickable while loading more - Don't persist paged URL parameter when infinite scroll is enabled - Check allLoadedRecords instead of feed for selection cleanup - Remove actor switch effect that causes infinite update loop
pfefferle
force-pushed
the
fix/infinite-scroll-bugs
branch
from
da0ffbe to
582a397
Compare
Member
Author
|
@pfefferle I think I'd just close this and create a new one based on tanstack router |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two critical bugs in the infinite scroll implementation for the social-web feed while eliminating an infinite update loop.
Changes
isLoadingMorefrom DataViewsisLoadingprop so items on page 1 remain clickable while page 2+ is loadingpagedURL parameter when infinite scroll is enabled, ensuring reloads always start from page 1 (standard infinite scroll UX)allLoadedRecordsinstead offeedto prevent premature selection clearing during page transitionsnormalizedViewcreating new object references on every renderKnown Issue
The actor switching state cleanup (Bug 1) has been removed to prevent the infinite loop. This will need to be addressed next with a different approach that doesn't trigger the loop.
Test Plan