Support PreeditText #532
Open
Support PreeditText #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very happy to see this , LGTM. |
搜索框的输入法定位和预输入仍有问题。
|
Contributor
Author
See #489 (comment) #524 (comment) This PR may not be related to this issue We may need to refactor it. |
realybin
force-pushed
the
feat/preedittext
branch
from
1d49ac6 to
13b6005
Compare
realybin
force-pushed
the
feat/preedittext
branch
from
13b6005 to
0df64d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure whether to underline text or how to do so efficiently. Visually, I don't see much difference between underlining and leaving it plain.
NOTE: I'd set the AvaloniaSampleVersion to 11.3.6 for getting this fix AvaloniaUI/Avalonia#18759
Fixes #524
Achieving Chromium's effect where pre-edited text compresses subsequent content would likely incur performance overhead.
Therefore, I've implemented the same effect as Visual Studio.