[TEST PR] containerapp function get/liust, keys, invocations commands #9419

khushishah513 · 2025-11-12T13:15:36Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

resolving some of the comments on PR

resolving comments on PR

fixing style error

merging main

azure-client-tools-bot-prd · 2025-11-12T13:15:39Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd containerapp debug cmd containerapp debug added parameter debug_command

⚠️ 1011 - SubgroupAdd containerapp function sub group containerapp function added

azure-client-tools-bot-prd · 2025-11-12T13:15:42Z

Hi @khushishah513,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2025-11-12T13:15:45Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-11-12T13:15:50Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2025-11-12T13:16:46Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2025-11-12T13:19:41Z

Hi @khushishah513

Release Suggestions

Module: containerapp

Update VERSION to 1.2.0b6 in src/containerapp/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull Request Overview

This pull request introduces comprehensive support for Azure Functions on Container Apps, including commands for managing functions, function keys, and invocation monitoring. The PR adds new commands for listing/showing functions, managing function keys, and retrieving invocation telemetry from Application Insights.

Key Changes

Added new containerapp function commands for listing and showing functions
Implemented function keys management (show, list, set operations)
Added function invocations monitoring (summary and traces from App Insights)
Enhanced the debug command to support executing commands inside containers
Created new decorator classes for functions and function keys operations

Reviewed Changes

Copilot reviewed 15 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
custom.py	Added command implementations for function operations and debug command enhancement
containerapp_functions_decorator.py	New decorator classes for function list/show/invocations operations
containerapp_function_keys_decorator.py	New decorator classes for function keys operations
containerapp_debug_command_decorator.py	New decorator for executing commands in containers
_validators.py	Added validation functions for function app operations
_utils.py	Added utility functions for replica selection and command execution
commands.py	Registered new command groups and transformers
test_containerapp_function.py	Comprehensive test suite for function operations
utils.py	Added helper for v1 environment preparation

Copilot · 2025-11-12T13:26:47Z

src/containerapp/azext_containerapp/tests/latest/test_containerapp_function.py

+# --------------------------------------------------------------------------------------------
+
+from subprocess import run
+from time import sleep


The imports include both subprocess.run and time.sleep, but the code uses time.sleep throughout instead of the imported sleep. Either use the imported sleep or remove the from time import sleep import to be consistent.

Suggested change

from time import sleep

Copilot · 2025-11-12T13:26:48Z

src/containerapp/azext_containerapp/containerapp_functions_decorator.py

+                container_app_name=name
+            )
+
+            if revision_name and revision_name is not None:


The condition if revision_name and revision_name is not None: is redundant. If revision_name is truthy, it's already not None. Simplify to just if revision_name: for better readability.

Copilot · 2025-11-12T13:26:48Z

src/containerapp/azext_containerapp/_utils.py

+
+
+def get_random_replica(cmd, resource_group_name, container_app_name, revision_name):
+    logger.debug(f"Getting random replica for container app: name='{container_app_name}', resource_group='{resource_group_name}', revision='{revision_name}'")


The function is named get_random_replica but actually selects the replica with the latest creation time (line 867), not a random one. Consider renaming to get_latest_replica or get_running_replica to accurately reflect the behavior.

Copilot · 2025-11-12T13:26:48Z

src/containerapp/azext_containerapp/containerapp_functions_decorator.py

+                container_app_name=name
+            )
+
+            if revision_name and revision_name is not None:


The same redundant condition appears on line 148. Simplify to if revision_name: for consistency.

Copilot · 2025-11-12T13:26:49Z

src/containerapp/azext_containerapp/_utils.py

+import random



The random module is imported but never used in the code. Remove this unused import.

Suggested change

import random

Copilot · 2025-11-12T13:26:49Z

src/containerapp/azext_containerapp/tests/latest/test_containerapp_function.py

+         # Test: Show functions with non-existent revision should fail
+        with self.assertRaisesRegex(Exception, ".*"):


[nitpick] Missing blank line before comment (PEP 8 style). Add a blank line before line 142 to improve readability.

Copilot · 2025-11-12T13:26:49Z

src/containerapp/azext_containerapp/_ssh_utils.py

+        debug_url = (f"wss://{proxy_api_url}/subscriptions/{sub}/resourceGroups/{resource_group_name}/"
+                     f"containerApps/{name}/revisions/{revision}/replicas/{replica}/debug"
+                     f"?targetContainer={container}")
+        return debug_url




[nitpick] The URL construction now splits the path across three lines with a trailing slash in the first line. This improves readability but introduces an unnecessary intermediate variable. Consider keeping the original inline return or adjusting line breaks to align with other URL constructions in the codebase.

Suggested change

debug_url = (f"wss://{proxy_api_url}/subscriptions/{sub}/resourceGroups/{resource_group_name}/"

f"containerApps/{name}/revisions/{revision}/replicas/{replica}/debug"

f"?targetContainer={container}")

return debug_url

return (f"wss://{proxy_api_url}/subscriptions/{sub}/resourceGroups/{resource_group_name}/"

f"containerApps/{name}/revisions/{revision}/replicas/{replica}/debug"

f"?targetContainer={container}")

khushishah513 added 14 commits October 15, 2025 07:39

Az function cli changes

ab26157

adding all the missing files

fb17f16

fixing style errors

c01dbdf

resolving some of the comments

aac3e98

Merge pull request #19 from khushishah513/function-comments

c8f08e2

resolving some of the comments on PR

resolving comments

fdc2937

resolving comments

9b20d74

Merge pull request #20 from khushishah513/function-comments

4b1719e

resolving comments on PR

fixing style error

47ef9ad

Merge pull request #21 from khushishah513/function-comments

ce1123c

fixing style error

merging main

253c525

Merge pull request #22 from khushishah513/function-comments

379dedb

merging main

tests

025c3be

adding app insight extension

7acaf7c

khushishah513 requested a review from howang-ms as a code owner November 12, 2025 13:15

Copilot AI review requested due to automatic review settings November 12, 2025 13:15

khushishah513 requested review from Greedygre and Juliehzl as code owners November 12, 2025 13:15

azure-client-tools-bot-prd bot added this to the December 2025 (2025-12-02) milestone Nov 12, 2025

microsoft-github-policy-service bot requested review from jsntcy, ruslany, sanchitmehta, wangzelin007, yanzhudd, yonzhan and zhoxing-ms November 12, 2025 13:15

microsoft-github-policy-service bot requested review from JennyLawrance, chinadragon0515, ebencarek, jijohn14, pagariyaalok, torosent, vinisoto and vturecek November 12, 2025 13:16

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Nov 12, 2025

microsoft-github-policy-service bot assigned zhoxing-ms Nov 12, 2025

microsoft-github-policy-service bot added the ContainerApp label Nov 12, 2025

Copilot started reviewing on behalf of khushishah513 November 12, 2025 13:16 View session

Copilot finished reviewing on behalf of khushishah513 November 12, 2025 13:17

Copilot AI reviewed Nov 12, 2025

View reviewed changes

khushishah513 added 2 commits November 12, 2025 13:53

test extension add app-insights

b4106db

adding quotes with ***

7dccb4f

khushishah513 closed this Nov 13, 2025



		def get_random_replica(cmd, resource_group_name, container_app_name, revision_name):
		logger.debug(f"Getting random replica for container app: name='{container_app_name}', resource_group='{resource_group_name}', revision='{revision_name}'")

		# Test: Show functions with non-existent revision should fail
		with self.assertRaisesRegex(Exception, ".*"):

[TEST PR] containerapp function get/liust, keys, invocations commands #9419

[TEST PR] containerapp function get/liust, keys, invocations commands #9419

Uh oh!

Conversation

khushishah513 commented Nov 12, 2025

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Nov 12, 2025

Uh oh!

yonzhan commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

CodeGen Tools Feedback Collection

Uh oh!

github-actions bot commented Nov 12, 2025

Release Suggestions

Module: containerapp

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

azure-client-tools-bot-prd bot commented Nov 12, 2025 •

edited

Loading