Skip to content

[Safeguards] Fix verb tense in help text and add pre-existence check #9433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Safeguards] Fix verb tense in help text and add pre-existence check #9433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9e6577
[AKS] Fix verb tense in safeguards help text
Nov 17, 2025
382e084
Add pre-existence check to safeguards create and fix duplicate HISTOR…
Nov 17, 2025
35560d2
Move bastion fix to 19.0.0b17 per review feedback
Nov 18, 2025
5e91a87
Fix safeguards create command AAZ context access and add missing CLIE…
Nov 18, 2025
ba7e1d8
Move duplicate check logic from AAZ-generated file to custom class
Nov 18, 2025
8386e6d
Regenerate test recordings after moving duplicate check to custom class
Nov 18, 2025
3522e61
Add fresh test recordings for all three safeguards tests
Nov 19, 2025
bae5bb1
Fix linting errors and regenerate test recordings
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++

19.0.0b17
+++++++
* `az aks safeguards`: Fix verb tense in help text and examples to use first-person imperative verbs per Azure CLI guidelines.

19.0.0b16
+++++++
* `az aks bastion`: Correctly configure `$KUBECONFIG` values for tunneling traffic into a private AKS cluster.

19.0.0b16
Expand Down
6 changes: 3 additions & 3 deletions src/aks-preview/azext_aks_preview/aaz/latest/aks/safeguards/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
class Create(AAZCommand):
"""Enable Deployment Safeguards for a Managed Cluster

:example: Creates a DeploymentSafeguards resource at Warn level with a managed cluster resource id
:example: Create a DeploymentSafeguards resource at Warn level with a managed cluster resource id
az aks safeguards create --resource /subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.ContainerService/managedClusters/cluster1 --level Warn

:example: Creates a DeploymentSafeguards resource at Warn level using subscription, resourcegroup, and name tags
:example: Create a DeploymentSafeguards resource at Warn level using subscription, resourcegroup, and name tags
az aks safeguards create --subscription subid1 -g rg1 -n cluster1 --level Warn

:example: Create a DeploymentSafeguards resource at Warn level with ignored namespaces
az aks safeguards create -g rg1 -n mc1 --excluded-ns ns1 ns2 --level Warn

:example: Creates a DeploymentSafeguards resource at Warn level with pod security standards level set to Baseline
:example: Create a DeploymentSafeguards resource at Warn level with pod security standards level set to Baseline
az aks safeguards create --managed-cluster subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.ContainerService/managedClusters/cluster1 --level Warn --pss-level Baseline
"""

Expand Down
4 changes: 2 additions & 2 deletions src/aks-preview/azext_aks_preview/aaz/latest/aks/safeguards/_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
class Delete(AAZCommand):
"""Disable Deployment Safeguards for a Managed Cluster

:example: Deletes a DeploymentSafeguard resource by managed cluster id
:example: Delete a DeploymentSafeguard resource by managed cluster id
az aks safeguards delete -c subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.ContainerService/managedClusters/cluster1

:example: Deletes a DeploymentSafeguard resource with resourceGroup and clusterName arguments
:example: Delete a DeploymentSafeguard resource with resourceGroup and clusterName arguments
az aks safeguards delete -g rg1 -n cluster1
"""

Expand Down
4 changes: 2 additions & 2 deletions src/aks-preview/azext_aks_preview/aaz/latest/aks/safeguards/_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
class Show(AAZCommand):
"""Show Deployment Safeguards Configuration for a Managed Cluster

:example: Gets a DeploymentSafeguard resource by managed cluster id
:example: Get a DeploymentSafeguard resource by managed cluster id
az aks safeguards show --managed-cluster subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.ContainerService/managedClusters/cluster1

:example: Gets a DeploymentSafeguard resource with resourceGroup and clusterName arguments
:example: Get a DeploymentSafeguard resource with resourceGroup and clusterName arguments
az aks safeguards show -g rg1 -n cluster1
"""

Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import find_packages, setup

VERSION = "19.0.0b16"
VERSION = "19.0.0b17"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down
Loading