Remove unnecessary emitter path #54057
Merged
+4
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove-unnecessary-emitter-path
JoshLove-msft
requested review from
dargilco,
glharper,
nick863 and
trangevi
as code owners
Copilot finished reviewing on behalf of
JoshLove-msft
November 20, 2025 17:23
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unnecessary emitterPackageJsonPath specification from the Azure.AI.Agents.Persistent library's configuration, which was causing incorrect categorization in the library inventory documentation.
Key Changes:
- Removed
emitterPackageJsonPath: eng/emitter-package.jsonfrom tsp-location.yaml - Updated library inventory to correctly classify Azure.AI.Agents.Persistent as a TSP-Old library instead of Unknown TypeSpec Generator
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/ai/Azure.AI.Agents.Persistent/tsp-location.yaml | Removed unnecessary emitterPackageJsonPath configuration line |
| doc/GeneratorMigration/Library_Inventory.md | Updated library categorization counts and tables to reflect the corrected classification of Azure.AI.Agents.Persistent |
christothes
approved these changes
Nov 20, 2025
jsquire
approved these changes
Nov 20, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default emitter being specified was not necessary and was messing up the library inventory tables