E2E workflow updates #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjaliratnam-msft
requested review from
jalauzon-msft,
kyleknap,
seanmcc-msft and
vincenttran-msft
as code owners
kyleknap
reviewed
May 22, 2025
Member
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Looks good. Just had some more comments. I like the approach of just adding it to the ci.yml. I think that is going to make it managing the workflows easier.
anjaliratnam-msft
force-pushed
the
e2e_workflow
branch
from
58340ec to
9323505
Compare
kyleknap
reviewed
May 28, 2025
Member
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Looks good. Just had one more comment and we should be good to merge it.
.github/workflows/ci.yml
Outdated
| python-version: ${{ matrix.python-version }} | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install -r requirements-dev.txt |
Member
There was a problem hiding this comment.
Let's remove the line for installing from requirements-dev.txt. Specifically, for end to end tests, we want to install it as close as we can to what it would be like if installing directly from PyPI, which likely means unpinned dependencies. So, by removing this line, it will make sure we can install the library using the latest versions of our dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the workflow so integration tests are run when there are pushes to main or PRs.