WIP: support dock spacers #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirchoni
force-pushed
the
support-spacers
branch
from
2f60613 to
8e51d56
Compare
Contributor
|
Hey @kspeyanski thank you for opening this PR. I like the idea and your WIP changes. I believe where we're currently at is that the CLI tool at least won't crash if spacers are present. It's another question how we might proceed to supporting spacers in docks on users' profiles. It may be straightforward. I'd like to look into it. Great to have your interest in contributing. I'm out of time for this week but I'll be back for more next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2 and #1 probably.
On macos you can insert custom spacers in the dock, thus the
parsedAppDataobject changes. Currently, I'm only handling the error, but might need some guidance on how to proceed with inserting an "spacer" image in the final result.