Skip to content

Conversation

@robertcsakany
Copy link
Member

@robertcsakany robertcsakany commented Oct 14, 2025

JNG-6328 Update Maven repositories to repository.judo.technology

@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

Renamed Maven server IDs and updated credentials across multiple GitHub Actions workflows, removed mirror configurations, and adjusted POM distributionManagement to new repository endpoints. Added a repositories section to POM with the new Judong repository. No build logic or public API changes.

Changes

Cohort / File(s) Summary
GitHub Actions workflows
.github/workflows/build-dependabot.yml, .github/workflows/build.yml, .github/workflows/bump-version.yml, .github/workflows/create-release-on-master.yml, .github/workflows/release.yml
Updated Maven server IDs to judong and judong-distribution; switched credentials to JUDONG_REPOSITORY_USER/PASSWORD; removed mirrors blocks; retained existing build steps.
Maven POM
pom.xml
In profiles/release-judong/distributionManagement, changed repository IDs to judong-distribution and updated URLs; normalized self-closing tags; added <repositories> with judong (releases enabled, snapshots disabled).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws—new routes to run,
Mirrors gone, the configs spun.
Repos shift, credentials true,
Snapshots, releases—clean and new.
In burrows of YAML and POM I dwell,
Hop-compile-hop—deployments swell. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states the primary change of updating Maven repositories to judo.technology and even includes the ticket identifier, succinctly summarizing the main intent without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description clearly states that Maven repository URLs are being updated to repository.judo.technology, which directly corresponds to the modifications in the pom.xml and GitHub workflow files. It is specific enough to indicate the nature of the changes without being off-topic or unrelated. Therefore, the description is appropriately aligned with the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/JNG-6328_ChangeMavenRepositories

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/release.yml (1)

55-63: Aligned with POM; minor check

Looks good. If judong and judong-distribution use different credentials, consider separate secrets; if same account, current setup is fine.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 477cffe and a9d487d.

📒 Files selected for processing (6)
  • .github/workflows/build-dependabot.yml (1 hunks)
  • .github/workflows/build.yml (1 hunks)
  • .github/workflows/bump-version.yml (1 hunks)
  • .github/workflows/create-release-on-master.yml (1 hunks)
  • .github/workflows/release.yml (1 hunks)
  • pom.xml (5 hunks)
🔇 Additional comments (6)
.github/workflows/create-release-on-master.yml (1)

40-48: Consistent migration to new repo IDs

IDs and credentials updated consistently. Nothing else to change here.

.github/workflows/bump-version.yml (1)

55-63: OK for a non-deploy workflow

Using only judong/judong-distribution servers (no OSSRH) is fine here since this job doesn’t deploy to Central.

.github/workflows/build-dependabot.yml (1)

49-57: Dependabot build: IDs/secrets updated correctly

Matches the new POM/server scheme. The dependabot-only guard keeps secrets safe.

pom.xml (2)

367-375: DistributionManagement updated; confirm upstream usage for both release/snapshot

IDs are correct. Using the same upstream URL for snapshotRepository and repository is OK if the upstream handles both. Please confirm that the upstream repo accepts snapshots on this path; otherwise, separate snapshot path may be required.


579-590: New repository entry looks correct; snapshots disabled

Judong repo added with releases enabled, snapshots disabled. Confirm you don’t need snapshot dependencies from judong; if you do, add a snapshots-enabled repo or a profile for snapshots.

.github/workflows/build.yml (1)

57-65: Server IDs match POM and no stale endpoints remain
build.yml entries for judong and judong-distribution align with POM repository IDs and URLs; confirm JUDONG_REPOSITORY_USER and JUDONG_REPOSITORY_PASSWORD secrets are configured in repo/org settings and scoped to this repo’s runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants