Add variable font support #1148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comprehensive support for variable fonts to the canvas library. Changes: - Added C++ FFI functions to query variable font axes and check if a font has variations - Extended text rendering to support custom variable font axis values - Added Rust bindings for new variable font functions - Exposed JavaScript API through GlobalFonts: - getVariationAxes(familyName, weight, width, slant): returns array of axis information - hasVariations(familyName, weight, width, slant): checks if font is variable - Added TypeScript definitions for FontVariationAxis interface - Created tests demonstrating the new functionality The implementation leverages Skia's existing variable font support through SkTypeface::getVariationDesignPosition() and allows setting variation coordinates via SkFontArguments::setVariationDesignPosition() in TextStyle. Variable fonts allow continuous interpolation of font properties like weight, width, slant, optical size, and custom axes, providing much more flexibility than traditional static fonts.
The TextStyle::setFontArguments method expects std::optional<SkFontArguments>, not a raw SkFontArguments object. This commit fixes the C++ compilation issue.
Skia's API has changed from (pointer, count) to SkSpan. Updated all
calls to getVariationDesignPosition to use the modern SkSpan API:
- Call with empty span {} to get count
- Call with {data, size} to retrieve coordinates
napi-rs doesn't support f32, only f64. Updated FontVariationAxis struct to use f64 for all float fields.
ES modules don't have __dirname by default. Use the standard pattern of dirname(fileURLToPath(import.meta.url)) to get the directory path, consistent with other test files in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive support for variable fonts to the canvas library.
Changes:
The implementation leverages Skia's existing variable font support through SkTypeface::getVariationDesignPosition() and allows setting variation coordinates via SkFontArguments::setVariationDesignPosition() in TextStyle.
Variable fonts allow continuous interpolation of font properties like weight, width, slant, optical size, and custom axes, providing much more flexibility than traditional static fonts.