Skip to content

Conversation

@ShivaGupta-14
Copy link
Contributor

@ShivaGupta-14 ShivaGupta-14 commented Nov 20, 2025

Description

This PR introduces a new TagSelector component that enhances the tagging workflow across the application.
The previous free-text tag input has been replaced with a searchable multi-select dropdown that also supports creating new tags directly from the selector.

Key Changes

  • New TagSelector Component

    • Adds a searchable dropdown to quickly find existing tags.
    • Supports selecting multiple tags with a clean UI.
    • Includes the ability to create new tags when no matching tag exists.
  • Integration in Task Dialogs

    • Replaced manual tag entry fields in Add Task and Edit Task dialogs.
    • Ensures consistent tagging behavior across the app.
  • Tag Management Improvements

    • Integrates existing user-defined tags (uniqueTags) into the selector.
    • Prevents inconsistent or typo-prone tags by removing free-text inputs.
  • Popover Fix

    • Removed Popover.Portal because it caused cursor detection and interaction issues when the selector was used inside dialogs.
  • Testing

    • Updated unit tests to mock TagSelector.
    • Added checks verifying:
      • New tag creation flow
      • Proper tag selection state updates
      • Correct rendering of existing tags

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Video : Link

Screenshots :

Screenshot 2025-11-20 at 5 33 15 PM Screenshot 2025-11-20 at 5 33 27 PM Screenshot 2025-11-20 at 5 33 40 PM

Copy link
Collaborator

@its-me-abhishek its-me-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix

Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@its-me-abhishek Thanks for the review! I’ve responded to the inline comments with my reasoning, but I’m open to any suggestions if you feel a different approach or structure would work better.

@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/210-tag-dropdown-selection branch 4 times, most recently from 8fec9c4 to cff668e Compare November 25, 2025 12:01
@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/210-tag-dropdown-selection branch 3 times, most recently from 46b78b3 to 82a8374 Compare December 2, 2025 14:13
Implemented new TagSelector component with searchable dropdown and create-tag support.
Replaced manual tag input in Add Task and Edit Task dialogs.
Integrated existing user-defined tags (uniqueTags) into the selector.
Removed Popover.Portal to fix cursor and interaction issues inside dialogs.
Updated tests to mock TagSelector and verify new tag state updates.

Improves tagging UX and prevents inconsistent or typo-prone tags.

Fixes: CCExtractor#210
@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/210-tag-dropdown-selection branch from 82a8374 to 54c6da6 Compare December 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reusable tags for Editing or Adding a task

2 participants