Implement m4s recording with recovery #1419
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces fragmented mp4 recording support and implements a recovery mechanism for incomplete recordings. Co-authored-by: richiemcilroy1 <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: richiemcilroy1 <[email protected]>
This commit introduces a new method for recording cursor events to a JSON Lines file (`.jsonl`) and updates the loading logic to prioritize this new format. This provides a more robust and efficient way to store and retrieve cursor data. Co-authored-by: richiemcilroy1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fragmented MP4 (M4S) recording for studio mode to enable recovery of incomplete recordings.
The previous recording method could lead to lost recordings if the application crashed mid-recording. By using fragmented MP4, video data is written incrementally, allowing the recovery mechanism to reconstruct a playable recording from the last successfully written fragment, even if the recording process is interrupted. This PR introduces a new fragmented MP4 muxer, integrates it into the recording pipeline for both Windows and macOS, and adds metadata tracking and editor-side recovery logic.