Skip to content

Conversation

@defi-failure
Copy link
Collaborator

What this PR does

Before this PR:
The cherryin-provider creates a chat model based on the model name.

After this PR:
The chat model is created based on the endpoint type. If the endpoint type is not specified, it falls back to using the model name.

Copy link
Collaborator

@MyPrototypeWhat MyPrototypeWhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This review was translated by Claude.

Can it run properly? The code looks fine. Additionally, you need to increment the version number and publish a new npm package.


Original Content

能跑通吗 看代码没问题,另外还需要版本号+1,再发个npm包

@defi-failure
Copy link
Collaborator Author

defi-failure commented Nov 19, 2025

Note

This issue/comment/review was translated by Claude.

It works, but there might be a potential issue. Previously, models that were not from Anthropic and Gemini would use the response API, but now with endpoint type-based judgment, most of them will use the chat API.

The version number can be changed first. Should the package be released before or after the merge?


Original Content

可以跑,但是可能有个潜在问题,之前不是anthropic和gemini的模型都会用response api,现在根据endpoint type判断的话大多走的是chat api

版本号可以先改,包是merge前发还是merge后发

@MyPrototypeWhat
Copy link
Collaborator

MyPrototypeWhat commented Nov 20, 2025

Note

This issue/comment/review was translated by Claude.

It works, but there might be a potential issue. Previously, models that were not from Anthropic and Gemini would use the response API, but now with endpoint type-based judgment, most of them will use the chat API.

The version number can be changed first. Should the package be released before or after the merge?

Release it before merge. If there are issues, we can still fix them in this PR.


Original Content

可以跑,但是可能有个潜在问题,之前不是anthropic和gemini的模型都会用response api,现在根据endpoint type判断的话大多走的是chat api

版本号可以先改,包是merge前发还是merge后发

merge前发吧 有问题还能在这个pr里改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants