Skip to content

Conversation

@smason
Copy link

@smason smason commented Jun 7, 2022

I struggled to understand what I was supposed to do when using the tool and it sounded like it's come up before

have tested locally under firefox and chrome and it seems to do the right thing

this is a somewhat hacky change, feel free to suggest alternatives!

smason added 2 commits June 7, 2022 19:41
a lot of the CSS didn't seem to be doing much so removed it, then again it's
been a while since I've done any fontend work
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for crc-annotations ready!

Name Link
🔨 Latest commit d34968b
🔍 Latest deploy log https://app.netlify.com/sites/crc-annotations/deploys/62b1f8e95b3bc20008062776
😎 Deploy Preview https://deploy-preview-24--crc-annotations.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danfishgold
Copy link
Collaborator

thanks for this! I really appreciate it
I'll have some time to go over the PR during the weekend :)

Copy link
Collaborator

@danfishgold danfishgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small notes :)

@smason
Copy link
Author

smason commented Jun 15, 2022

thanks for the comments! replying down here instead of piecemeal:

  • Popover sounds like a better name, changed
  • have added those CSS changes in
  • also tried adding some color to the popover. blue seems to be the conventional color to indicate information, so used that. gets my attention more, but not sure if it's a bit much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants