Replace JSON.parse(JSON.stringify()) with structuredClone() for better object cloning #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r object cloning - Use modern structuredClone() API when available for deep cloning - Maintains fallback to JSON method for compatibility - Fixes circular reference crashes that previously threw errors - Preserves type fidelity (Date, RegExp, undefined values) - Performance neutral to positive due to native implementation - Add comprehensive test suite covering all edge cases Fixes #1157
Since structuredClone is already used extensively throughout the codebase (20+ places), there's no need for JSON fallback. Simplifies implementation and removes redundant error handling. - Removed try/catch fallback logic from cloneObject() - Simplified test suite to match streamlined implementation - All 277 tests passing Fixes #1157
webfiltered
suggested changes
Jul 25, 2025
Contributor
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
In case you missed it during the meeting - you cannot simply drop this in as a replacement and expect it to work. It will break custom nodes, even if the frontend is fixed.
What is the tangible benefit of this disruption?
Contributor
Author
|
Can you explain why this breaks custom nodes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary JSON fallback logic from
cloneObject()sincestructuredCloneis already used extensively throughout the codebase (10+ locations). The fallback was originally added for compatibility, but analysis shows it's no longer needed.Why This Change is Safe
structuredClonealready used in critical paths without issuesWhy It Wasn't Done Earlier
structuredCloneonly became baseline supported in March 2022. The codebase has been gradually migrating to it, withcloneObject()being one of the last holdouts due to conservative timing.Changes
cloneObject()to usestructuredClone()directlyFixes Comfy-Org/ComfyUI_frontend#4696