Fixing endpoint checking and allocation #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes endpoint checking and allocation in the MCP Inspector integration (addressing issue #1010). The changes update how the AddMcpServer method validates and selects endpoints from MCP server resources.
Key Changes
- Added explicit check using
TryGetEndpointsto validate that endpoints exist before proceeding - Changed endpoint selection logic from preferring "https"/"http" endpoints to using the first available endpoint
- Updated error message to reflect the new validation approach
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResource.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResource.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010