Implement second ipd branch from scfly #5543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMarre
force-pushed
the
topic-ImplementSecondIPDBranchFromSCFLY
branch
3 times, most recently
from
925926e to
e9c1ad4
Compare
Member
|
@BrianMarre I made this a draft since there are still open PRs to be merged beforehand and I would like to avoid an "accidental" merge. |
Member
|
@BrianMarre #5542 has been merged and you could start resolving the merge conflicts. |
BrianMarre
force-pushed
the
topic-ImplementSecondIPDBranchFromSCFLY
branch
2 times, most recently
from
1449b27 to
da59b45
Compare
PrometheusPi
requested changes
Nov 28, 2025
Member
PrometheusPi
left a comment
PrometheusPi
left a comment
There was a problem hiding this comment.
Various parts are unclearly documented or differently implemented as the cited reference.
Also some minor code changes have been introduced that appear unnecessary.
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Outdated
Show resolved
Hide resolved
...e/picongpu/particles/atomicPhysics/ionizationPotentialDepression/stage/CalculateIPDInput.hpp
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/debug/TestIonizationPotentialDepression.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Show resolved
Hide resolved
...congpu/particles/atomicPhysics/ionizationPotentialDepression/kernel/CalculateIPDInput.kernel
Outdated
Show resolved
Hide resolved
Member
|
@BrianMarre Could it be that you marked some issues raised as fixed but did not push these fixes yet? |
Member
Author
|
yes, sorry, give me a bit of time |
Member
Author
|
@PrometheusPi the new version including your comments is now ready for review. |
ci:picongpu
BrianMarre
force-pushed
the
topic-ImplementSecondIPDBranchFromSCFLY
branch
from
f25fcec to
f9835b8
Compare
ci:picongpu
BrianMarre
force-pushed
the
topic-ImplementSecondIPDBranchFromSCFLY
branch
from
f9835b8 to
255b167
Compare
PrometheusPi
requested changes
Dec 2, 2025
Member
PrometheusPi
left a comment
PrometheusPi
left a comment
There was a problem hiding this comment.
just a typo - looks good.
| // (1/(1/unit_length^3))^(1/3) = unit_length | ||
| float_X const ionSphereRadius = math::pow( | ||
| 0.75_X * (chargeStateAsFloat + 1._X) / (picongpu::PI * superCellConstantInput.freeElectronDensity), | ||
| 1. / 3.); |
| float_X const stewartPyattIPD | ||
| = superCellConstantInput.temperatureTimesk_Boltzman | ||
| * (math::pow((3._X * (superCellConstantInput.zStar + 1._X) * K + 1._X), 2._X / 3._X) - 1._X) | ||
| / (2._X * (superCellConstantInput.zStar + 1._X)); |
include/picongpu/particles/atomicPhysics/ionizationPotentialDepression/StewartPyattIPD.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Pausch <[email protected]>
PrometheusPi
approved these changes
Dec 2, 2025
PrometheusPi
merged commit a774def
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the second branch used in the SCFLY-IPD calculation