Checkpoint period from cmdline args ignored #5568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
added
bug
PrometheusPi
approved these changes
Dec 2, 2025
Contributor
|
Tested via |
Member
|
The CI stopped continuing with further test jobs despite all previous ones having passed. I triggered the next level of jobs. If these hang-ups reoccur, we might need to investigate. |
PrometheusPi
merged commit 0a07e0e
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #5493, I introduced a bug where the command line argument
checkpoint periodwas ignored and not added to the internal sequence of checkpointing stepsseqCheckpointPeriod.This was because the call to intialize
seqCheckpointPeriodwas in the wrong place and called way too soon, beforecheckpoint periodwas actually set.